Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] parted: fix minor()/major() build failure due to glibc 2.28
Date: Mon, 10 Sep 2018 09:25:10 +0200	[thread overview]
Message-ID: <20180910092510.66b51de5@windsurf.home> (raw)
In-Reply-To: <20180909172917.55169-1-giulio.benetti@micronovasrl.com>

Hello,

On Sun,  9 Sep 2018 19:29:17 +0200, Giulio Benetti wrote:

> diff --git a/package/parted/0005-libparted-include-sys-sysmacros.h-to-compile-with-gl.patch b/package/parted/0005-libparted-include-sys-sysmacros.h-to-compile-with-gl.patch
> new file mode 100644
> index 0000000000..63dda4c4ff
> --- /dev/null
> +++ b/package/parted/0005-libparted-include-sys-sysmacros.h-to-compile-with-gl.patch
> @@ -0,0 +1,33 @@
> +From 715e3e937536326af272c45a86cc3765f00297f7 Mon Sep 17 00:00:00 2001
> +From: Giulio Benetti <giulio.benetti@micronovasrl.com>
> +Date: Sun, 9 Sep 2018 19:19:19 +0200
> +Subject: [PATCH] libparted: include <sys/sysmacros.h> to compile with
> + glibc-2.28
> +
> +glibc 2.28 no longer includes <sys/sysmacros.h> from <sys/types.h>,
> +and therefore <sys/sysmacros.h> must be included explicitly when
> +major()/minor() are used.
> +
> +Include <sys/sysmacros.h> into libparted/arch/linux.c where minor() and
> +major() macros are used.
> +
> +Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>

Please backport upstream commit
ba5e0451b51c983e40afd123b6e0d3eddb55e610 instead of coming up with your
one fix. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-09-10  7:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-09 17:29 [Buildroot] [PATCH] parted: fix minor()/major() build failure due to glibc 2.28 Giulio Benetti
2018-09-10  7:25 ` Thomas Petazzoni [this message]
2018-09-10 10:49   ` Giulio Benetti
2018-09-10 11:46     ` Yegor Yefremov
2018-09-10 12:08       ` Thomas Petazzoni
2018-09-10 13:48         ` Giulio Benetti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910092510.66b51de5@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox