Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/mongodb: add patch to compile with glibc >= 2.28
Date: Wed, 12 Sep 2018 10:52:28 +0200	[thread overview]
Message-ID: <20180912105228.1c0ec200@windsurf> (raw)
In-Reply-To: <20180912083447.5169-1-F.LaRoche@pilz.de>

Hello,

On Wed, 12 Sep 2018 10:34:47 +0200, Florian La Roche wrote:
> glibc 2.28 no longer includes <sys/sysmacros.h> from <sys/types.h>,
> and therefore <sys/sysmacros.h> must be included explicitly when
> major()/minor() are used.
> 
> Signed-off-by: Florian La Roche <F.LaRoche@pilz.de>

Thanks a lot for this patch.

> ---
>  package/mongodb/mongodb.patch | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>  create mode 100644 package/mongodb/mongodb.patch
> 
> diff --git a/package/mongodb/mongodb.patch b/package/mongodb/mongodb.patch
> new file mode 100644
> index 0000000000..d429b4e891
> --- /dev/null
> +++ b/package/mongodb/mongodb.patch

Since mongodb upstream is maintained in Git, we like to have a Git
formatted patch. So could you instead clone
https://github.com/mongodb/mongo.git, checkout the 3.3.4 tag, make the
fix, do a commit, and then "git format-patch HEAD^", and use the
generated 0001 file ?

BTW, I see that in the latest version of mongodb, this file no longer
exists. Our package of mongodb is quite old, so if you have some
specific interest in mongodb, it might be useful to update it. Or maybe
Sergio can comment on this.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-09-12  8:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12  8:34 [Buildroot] [PATCH 1/1] package/mongodb: add patch to compile with glibc >= 2.28 Florian La Roche
2018-09-12  8:52 ` Thomas Petazzoni [this message]
2018-09-12  9:49   ` [Buildroot] Antwort: " Florian La Roche
2018-09-12 12:40   ` Florian La Roche
2018-09-12 18:06     ` [Buildroot] " Sergio Prado
2018-09-12 18:53       ` Thomas Petazzoni
2018-09-16 19:57 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180912105228.1c0ec200@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox