From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] gpm: fix major() build failure due to glibc 2.28
Date: Sun, 16 Sep 2018 10:22:36 +0200 [thread overview]
Message-ID: <20180916102236.27bdcec9@windsurf> (raw)
In-Reply-To: <20180915132359.85323-1-giulio.benetti@micronovasrl.com>
Hello,
On Sat, 15 Sep 2018 15:23:59 +0200, Giulio Benetti wrote:
> glibc 2.28 no longer includes <sys/sysmacros.h> from <sys/types.h>,
> and therefore <sys/sysmacros.h> must be included explicitly when major()
> is used.
>
> This commit adds a patch to directly include <sys/sysmacros.h> into
> open_console.c file where major() macro is used.
>
> Patch has been taken from gpm upstream commit:
> https://github.com/telmich/gpm/commit/b350aee4ea5785a75cb6ad770f6b768c506ebb70
>
> Fixes:
> http://autobuild.buildroot.net/results/f53/f5373a567de619375746f1dcfe312971b85bb810/
> http://autobuild.buildroot.net/results/227/227a7edf9304d85645d3e7fa0f930fe2e9b6e752/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> .../gpm/0005-fix-building-w-newer-glibc.patch | 32 +++++++++++++++++++
> 1 file changed, 32 insertions(+)
> create mode 100644 package/gpm/0005-fix-building-w-newer-glibc.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-09-16 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 13:23 [Buildroot] [PATCH v2] gpm: fix major() build failure due to glibc 2.28 Giulio Benetti
2018-09-16 8:22 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180916102236.27bdcec9@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox