From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Wed, 19 Sep 2018 16:07:57 +0200 Subject: [Buildroot] [RFC PATCH v3 1/1] support/kconfig: Bump to kconfig from Linux 4.17-rc2 In-Reply-To: <20180919152848.616fc616@windsurf> References: <20180919113615.27036-1-petr.vorel@gmail.com> <20180919152848.616fc616@windsurf> Message-ID: <20180919140756.GA2353@x230> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hi Thomas, > Thanks for working on this! > On Wed, 19 Sep 2018 13:36:15 +0200, Petr Vorel wrote: > > Signed-off-by: Petr Vorel > > --- > > Changes v2->v3: > > * Fix issues with building more that we need (menuconfig require > > unfortunately "make menuconfig" fails, because > > it wants ? reported by Thomas in [1]). > I don't understand this changelog. Could explain a bit more what you > mean here? Sure :). v2 build all code no matter whether it was actually needed. E.g. 'make menuconfig' built gconf (gtk) or qconf (qt). That's a bug you pointed out in [1]. I fixed it in v3. It was caused by removing ifeq clauses. Here is the diff v2 vs. v3: -hostprogs-y := conf nconf mconf kxgettext qconf gconf +hostprogs-y := conf + +ifeq ($(MAKECMDGOALS),nconf) + hostprogs-y += nconf +endif + +ifeq ($(MAKECMDGOALS),mconf) + hostprogs-y += mconf +endif + +ifeq ($(MAKECMDGOALS),update-po-config) + hostprogs-y += kxgettext +endif + +ifeq ($(MAKECMDGOALS),qconf) + qconf-target := 1 +endif + +ifeq ($(MAKECMDGOALS),gconf) + gconf-target := 1 +endif + +ifeq ($(qconf-target),1) + hostprogs-y += qconf +endif + +ifeq ($(gconf-target),1) + hostprogs-y += gconf +endif Another change I did is little changes in docs (support/kconfig/README.buildroot): -This is a copy of the kconfig code in the kernel (currently 3.13-rc5) tweaked +This is a copy of the kconfig code in the kernel (currently 4.17-rc2) tweaked ... cd support/kconfig.new + # zconf.lex.c and zconf.tab.c needs to be generated by 'make menuconfig' Kind regards, Petr