Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] scancpan: skip Dist::Zilla
Date: Fri, 21 Sep 2018 00:03:44 +0200	[thread overview]
Message-ID: <20180921000344.5ea3d57e@windsurf> (raw)
In-Reply-To: <20180820111623.23173-3-chrismcc@gmail.com>

Hello,

On Mon, 20 Aug 2018 04:16:22 -0700, Christopher McCrory wrote:
> Signed-off-by: Christopher McCrory <chrismcc@gmail.com>
> ---
>  utils/scancpan | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/utils/scancpan b/utils/scancpan
> index 6c90588ed4..c83730fa13 100755
> --- a/utils/scancpan
> +++ b/utils/scancpan
> @@ -603,6 +603,7 @@ sub fetch {
>              # we could use the host Module::CoreList data, because host perl and
>              # target perl have the same major version
>              next if ${$dep}{phase} eq q{develop};
> +	    next if ${$dep}{phase} eq q{x_Dist_Zilla};

I fixed the indentation issue that Fran?ois reported, and applied.

BTW, it is not really great that a comment made on August 21 is not
addressed by a new version of the patches while we are a month later.
I was in fact waiting for a new version to apply this change, but since
it didn't arrive, I ended up fixing it up before applying.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-09-20 22:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20 11:16 [Buildroot] [PATCH 0/3] scancpan patches Christopher McCrory
2018-08-20 11:16 ` [Buildroot] [PATCH 1/3] scancpan: wrap abstract if too long Christopher McCrory
2018-08-21  5:52   ` François Perrad
2018-09-20 22:04   ` Thomas Petazzoni
2018-08-20 11:16 ` [Buildroot] [PATCH 2/3] scancpan: skip Dist::Zilla Christopher McCrory
2018-08-21  5:46   ` François Perrad
2018-09-20 22:03   ` Thomas Petazzoni [this message]
2018-08-20 11:16 ` [Buildroot] [PATCH 3/3] scancpan: support more licenses Christopher McCrory
2018-08-21  5:55   ` François Perrad
2018-09-20 22:01   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921000344.5ea3d57e@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox