Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] chrony: Update to 3.4 v2
Date: Fri, 21 Sep 2018 15:43:46 +0200	[thread overview]
Message-ID: <20180921154346.0d938f63@windsurf> (raw)
In-Reply-To: <20180921121023.7490-1-ferdinand@ombud.nl>

Hello Ferdinand,

Thanks for your contribution. Since it's among your first contribution,
I'll try to give some guidance on our best practices.

On Fri, 21 Sep 2018 14:10:23 +0200, Ferdinand van Aartsen wrote:
> Patch 0002-util-fall-back-to-reading-dev-urandom-when-getrandom.patch was applied upstream in this version, so it can be deleted.

The commit log should be wrapped to ~72 characters.

> 
> Signed-off-by: Ferdinand van Aartsen <ferdinand@ombud.nl>

The "v2" should not be in the commit title (otherwise it becomes part
of the commit title in the Git history), but of the patch prefix, i.e
[PATCH v2]. To achieve this, you can do:

$ git format-patch -v2

or

$ git format-patch --subject-prefix="PATCH v2"

> ---

Also, here there should be a changelog of what changed between each
patch iteration.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-09-21 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-21 12:10 [Buildroot] [PATCH 1/1] chrony: Update to 3.4 v2 Ferdinand van Aartsen
2018-09-21 13:43 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921154346.0d938f63@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox