From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/pkg-waf: properly escape HOST_DIR when defining <pkg>_WAF
Date: Sun, 23 Sep 2018 15:45:58 +0200 [thread overview]
Message-ID: <20180923134558.GA9502@scaer> (raw)
In-Reply-To: <20180923133817.30704-1-thomas.petazzoni@bootlin.com>
Thomas, All,
On 2018-09-23 15:38 +0200, Thomas Petazzoni spake thusly:
> When <pkg>_NEEDS_EXTERNAL_WAF is set to YES, <pkg>_WAF is set to
> $(HOST_DIR)/bin/waf within the inner-waf-package macro. This reference
> to $(HOST_DIR) should use $$(HOST_DIR) so that it is properly expanded
> at the time of use, and not at the time of the macro expansion.
>
> In the current Buildroot, this doesn't cause any visible problem
> because $(HOST_DIR) points to the same directory for all
> packages. However, with per-package host/target directories, this is
> no longer the case. It causes a build issue because it tries to use
> "waf" from the global host directory, which doesn't exist during the
> build.
>
> This commit fixes the following build issue with per package
> host/target directories:
>
> /home/test/autobuild/run/instance-2/output/per-package/mpv/host/bin/python2: can't open file '/home/test/autobuild/run/instance-2/output/host/bin/waf': [Errno 2] No such file or directory
> make: *** [/home/test/autobuild/run/instance-2/output/build/mpv-0.27.2/.stamp_configured] Error 2
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-waf.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/pkg-waf.mk b/package/pkg-waf.mk
> index e5b606f063..3288dd63a0 100644
> --- a/package/pkg-waf.mk
> +++ b/package/pkg-waf.mk
> @@ -44,7 +44,7 @@ $(2)_NEEDS_EXTERNAL_WAF ?= NO
> # If the package does not have its own waf, use our own.
> ifeq ($$($(2)_NEEDS_EXTERNAL_WAF),YES)
> $(2)_DEPENDENCIES += host-waf
> -$(2)_WAF = $(HOST_DIR)/bin/waf
> +$(2)_WAF = $$(HOST_DIR)/bin/waf
> else
> $(2)_WAF = ./waf
> endif
> --
> 2.14.4
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-09-23 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-23 13:38 [Buildroot] [PATCH] package/pkg-waf: properly escape HOST_DIR when defining <pkg>_WAF Thomas Petazzoni
2018-09-23 13:45 ` Yann E. MORIN [this message]
2018-09-25 20:24 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180923134558.GA9502@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox