From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 25 Sep 2018 22:24:53 +0200 Subject: [Buildroot] [PATCH] package/pkg-waf: properly escape HOST_DIR when defining _WAF In-Reply-To: <20180923133817.30704-1-thomas.petazzoni@bootlin.com> References: <20180923133817.30704-1-thomas.petazzoni@bootlin.com> Message-ID: <20180925222453.3418944f@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sun, 23 Sep 2018 15:38:17 +0200, Thomas Petazzoni wrote: > When _NEEDS_EXTERNAL_WAF is set to YES, _WAF is set to > $(HOST_DIR)/bin/waf within the inner-waf-package macro. This reference > to $(HOST_DIR) should use $$(HOST_DIR) so that it is properly expanded > at the time of use, and not at the time of the macro expansion. > > In the current Buildroot, this doesn't cause any visible problem > because $(HOST_DIR) points to the same directory for all > packages. However, with per-package host/target directories, this is > no longer the case. It causes a build issue because it tries to use > "waf" from the global host directory, which doesn't exist during the > build. > > This commit fixes the following build issue with per package > host/target directories: > > /home/test/autobuild/run/instance-2/output/per-package/mpv/host/bin/python2: can't open file '/home/test/autobuild/run/instance-2/output/host/bin/waf': [Errno 2] No such file or directory > make: *** [/home/test/autobuild/run/instance-2/output/build/mpv-0.27.2/.stamp_configured] Error 2 > > Signed-off-by: Thomas Petazzoni > --- > package/pkg-waf.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com