From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Perez de Castro Date: Thu, 27 Sep 2018 15:44:11 +0300 Subject: [Buildroot] [PATCH 2/5] webkitgtk: add dependency on the woff2 package In-Reply-To: <87tvmbw4qb.fsf@dell.be.48ers.dk> References: <20180922235333.85642-1-aperez@igalia.com> <20180922235333.85642-3-aperez@igalia.com> <20180925225255.3fe01107@windsurf> <20180927124148.GB16720@momiji> <87tvmbw4qb.fsf@dell.be.48ers.dk> Message-ID: <20180927154411.GH16720@momiji> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Peter, On Thu, 27 Sep 2018 13:37:48 +0200, Peter Korsgaard wrote: > >>>>> "Adrian" == Adrian Perez de Castro writes: > > Hi, > > >> However, since woff2 has very few dependencies, and > >> woff2+brotli+host-pkgconf build in 19 seconds, it's nothing compared to > >> webkitgtk, so I applied your patch. > > > I will make a follow-up patch to make WOFF2 optional. I think it should be > > fine to enable it by default if BR2_PACKAGE_WOFF2 is enabled, and add a line > > in the help description telling that it is recommended to enable it. > > Correct. Now that we have updated kconfig we could even consider using > the imply keyword to enable woff2 by default if it is really an option > that most people should enable: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=237e3ad0f195d8fd34f1299e45f04793832a16fc This is just perfect. Thanks for pointing this out :-) Cheers, -Adri?n -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available URL: