Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/cups-filters: Add patch to fix build when using poppler 0.69.0
Date: Sat, 6 Oct 2018 16:00:07 +0200	[thread overview]
Message-ID: <20181006160007.26b20069@windsurf> (raw)
In-Reply-To: <20181005133019.1061-2-olivier.schonken@gmail.com>

Hello,

On Fri,  5 Oct 2018 15:30:19 +0200, Olivier Schonken wrote:
> This patch lets cups-filters only use gMemReport and memCheck functions
> if poppler version less than 0.69.0
> 
> The poppler project removed the memCheck and gMemReport functions in
> commits c362ab1b97f20c5b73b3bad8d52015f679178748 - Remove DEBUG_MEM
> from Object since this uses RAII now and hence cannot leak.
> (The existing tracking also is not thread-safe and hence unreliable.)
> 
> and
> 
> f89446f6917a869b0f1a80fcc8ce81a7213dade4 - Remove generic heap debugging
> from gmem since external tools and compiler instrumentation achieve the
> same effect.
> 
> A pull-request for the patch has also been created upstream at
> https://github.com/OpenPrinting/cups-filters/pull/66
> 
> Signed-off-by: Olivier Schonken <olivier.schonken@gmail.com>
> ---
>  ...ed-memCheck-and-gMemReport-functions.patch | 79 +++++++++++++++++++
>  1 file changed, 79 insertions(+)
>  create mode 100644 package/cups-filters/0002-Poppler-removed-memCheck-and-gMemReport-functions.patch

Applied to master, thanks. Thanks a lot for having submitted the patch
upstream, it has already been merged, which is nice!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-10-06 14:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-05 13:30 [Buildroot] [PATCH 1/2] package/cups-filters: bump to version 1.21.3 Olivier Schonken
2018-10-05 13:30 ` [Buildroot] [PATCH 2/2] package/cups-filters: Add patch to fix build when using poppler 0.69.0 Olivier Schonken
2018-10-06 14:00   ` Thomas Petazzoni [this message]
2018-10-06 13:59 ` [Buildroot] [PATCH 1/2] package/cups-filters: bump to version 1.21.3 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181006160007.26b20069@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox