From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Mon, 8 Oct 2018 17:55:56 +0200 Subject: [Buildroot] [PATCH 1/1] package/ltp-testsuite: add upstream patches In-Reply-To: <20181005064525.28631-1-F.LaRoche@pilz.de> References: <20181005064525.28631-1-F.LaRoche@pilz.de> Message-ID: <20181008175556.4bc9a087@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello Florian, Thanks for working on ltp! On Fri, 5 Oct 2018 08:45:25 +0200, Florian La Roche wrote: > Add patches from the upstream ltp-testsuite github > repository to compile correctly. "compile correctly" is very vague. Which issues is this fixing ? It seems like the statx patch is fixing a build issue with glibc 2.28. If that is the case, it should be explained in the commit log, and a reference to the autobuilder failure should be added (see http://autobuild.buildroot.net/?reason=ltp% for all ltp-testsuite build failures). The commit title should then be fixed to be: package/ltp-testsuite: fix build with glibc 2.28 > package/ltp-testsuite/0002-execve05.patch | 44 +++++++++++++++++++++++ This is a runtime fix, it should be added a separate patch, explaining why it should be added. Also, please use "git format-patch" to generate the patches, and keep the file name generated by git format-patch for the patches. > diff --git a/package/ltp-testsuite/0002-execve05.patch b/package/ltp-testsuite/0002-execve05.patch > new file mode 100644 > index 0000000000..06e40c54e1 > --- /dev/null > +++ b/package/ltp-testsuite/0002-execve05.patch > @@ -0,0 +1,44 @@ > +From 6f61cad559df8791add50aa8d053ca77cd97c594 Mon Sep 17 00:00:00 2001 > +From: "Allen, John" > +Date: Wed, 26 Sep 2018 14:31:37 +0000 > +Subject: [PATCH] runtest/{ltplite, stress.part3}: Update execve05 calling > + convention > + > +The calling convention for execve05 was recently changed and was updated > +in runtest/syscalls when the change was introduced, but not for other > +runtest files where execve05 is called. Update all calls to execve05 to > +use the new calling convention. > + > +Signed-off-by: John Allen > +Acked-by: Cyril Hrubis Please add your Signed-off-by to patches added in Buildroot. > diff --git a/package/ltp-testsuite/0004-statx.patch b/package/ltp-testsuite/0004-statx.patch > new file mode 100644 > index 0000000000..7b9002d708 > --- /dev/null > +++ b/package/ltp-testsuite/0004-statx.patch > @@ -0,0 +1,26 @@ > +This is based on 0003-statx.patch so that autoconf does not have to run again. > + As Petr suggested, we prefer to add AUTORECONF = YES in ltp-testsuite.mk. Just add something like this: # 0004-blablalba.patch LTP_TESTSUITE_AUTORECONF = YES Could you fix those minor details, and send an updated version of your patch ? Thanks, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com