From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] package/asterisk: enable for non-glibc toolchains
Date: Tue, 9 Oct 2018 15:09:16 +0200 [thread overview]
Message-ID: <20181009150916.1703c4ef@windsurf> (raw)
In-Reply-To: <20181003131358.28002-2-bernd.kuhls@t-online.de>
Hello,
On Wed, 3 Oct 2018 15:13:56 +0200, Bernd Kuhls wrote:
> Quoting Yann:
> http://lists.busybox.net/pipermail/buildroot/2017-September/203004.html
>
> "As a final stroke of genius, asterisk checks for the re-entrant variant
> of res_ninit(), and concludes that all such functions are available,
> including res_nsearch(). Uclibc-ng has the former but not the latter, so
> the build fails. Since there is no cache variable for that check, we
> can't pre-feed that result to configure, and fixing it is a bigger
> endeavour. So we make asterisk depend on glibc for now, until someone
> is brave enough to fix it."
>
> This hack was copied from Optware:
> https://github.com/Optware/Optware-ng/blob/master/make/asterisk13.mk#L331
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/asterisk/Config.in | 6 ++----
> package/asterisk/asterisk.mk | 4 ++++
> 2 files changed, 6 insertions(+), 4 deletions(-)
I agree with Arnout here, we want to fix this with a proper autoconf
check. I've marked this patch as Changes Requested. Could you rework it?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-09 13:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 13:13 [Buildroot] [PATCH 1/4] package/asterisk: bump version to 14.7.8 Bernd Kuhls
2018-10-03 13:13 ` [Buildroot] [PATCH 2/4] package/asterisk: enable for non-glibc toolchains Bernd Kuhls
2018-10-08 17:19 ` Arnout Vandecappelle
2018-10-08 19:45 ` Yann E. MORIN
2018-10-09 13:09 ` Thomas Petazzoni [this message]
2018-10-03 13:13 ` [Buildroot] [PATCH 3/4] package/spandsp: new package Bernd Kuhls
2018-10-09 13:14 ` Thomas Petazzoni
2018-10-12 16:56 ` Yann E. MORIN
2018-10-03 13:13 ` [Buildroot] [PATCH 4/4] package/asterisk: add optional spandsp support Bernd Kuhls
2018-10-09 13:14 ` Thomas Petazzoni
2018-10-09 13:08 ` [Buildroot] [PATCH 1/4] package/asterisk: bump version to 14.7.8 Thomas Petazzoni
2018-12-23 21:33 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009150916.1703c4ef@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox