From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Seiderer <ps.report@gmx.net>
Date: Tue, 9 Oct 2018 23:13:46 +0200
Subject: [Buildroot] [PATCH] meson: Use AR via wrapper
In-Reply-To: <20181009203406.GM2869@scaer>
References: <20181009192422.20809-1-abrodkin@synopsys.com>
 <20181009203406.GM2869@scaer>
Message-ID: <20181009231346.156ddb0d@gmx.net>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

Hello Alexey,

On Tue, 9 Oct 2018 22:34:06 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Alexey, All,
> 
> On 2018-10-09 22:24 +0300, Alexey Brodkin spake thusly:
> > If building with LTO enabled we need to use GCC wrapper for AR otherwise
> > archives get created improperly and we see a lot of unresolved symbols
> > on finla linkage.

>From quick review another minor nit: s/finla/final/

Will try to test the patch the next days...

Regards,
Peter

> > 
> > In particular this allows to build SystemD with LTO.
> 
> This is just 'systemd', not SystemD, or any other case-mangling on it
> https://www.freedesktop.org/wiki/Software/systemd/ ;-)
> 
> There, I'm done with the nit-picking. ;-) Now read on, for the real
> review lies below...
> 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> > Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr>
> > Cc: Mark Corbin <mark.corbin@embecosm.com>
> > Cc: Peter Korsgaard <peter@korsgaard.com>
> > Cc: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  package/meson/cross-compilation.conf.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/package/meson/cross-compilation.conf.in b/package/meson/cross-compilation.conf.in
> > index 0eec74087b..de4600cc58 100644
> > --- a/package/meson/cross-compilation.conf.in
> > +++ b/package/meson/cross-compilation.conf.in
> > @@ -6,7 +6,7 @@
> >  [binaries]
> >  c = '@TARGET_CROSS at gcc'
> >  cpp = '@TARGET_CROSS at g++'
> > -ar = '@TARGET_CROSS at ar'
> > +ar = '@TARGET_CROSS at gcc-ar'
> 
> I was curioous as to see for how long gcc provided that wrapper. It
> turns out that at least 4.9 did.
> 
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> 
> Regards,
> Yann E. MORIN.
> 
> >  strip = '@TARGET_CROSS at strip'
> >  pkgconfig = '@HOST_DIR@/usr/bin/pkg-config'
> >  
> > -- 
> > 2.16.2
> > 
> > _______________________________________________
> > buildroot mailing list
> > buildroot at busybox.net
> > http://lists.busybox.net/mailman/listinfo/buildroot
>