From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] poco: disable fpenvironment for MIPS without FPU
Date: Wed, 10 Oct 2018 08:45:02 +0200 [thread overview]
Message-ID: <20181010084502.04f1cf7e@windsurf> (raw)
In-Reply-To: <51cdb909-89fd-6832-0988-f29ab95dbf74@mind.be>
Hello,
On Tue, 9 Oct 2018 22:13:10 +0200, Arnout Vandecappelle wrote:
> The commit message is still very vague. I think I understand it though,
> something like:
Yes, I agree the commit log was still too vague.
> > +# MIPS without FPU
> > +ifeq ($(BR2_mips)$(BR2_mipsel)$(BR2_mips64)$(BR2_mips64el):$(BR2_MIPS_SOFT_FLOAT),y:y)
>
> BR2_MIPS_SOFT_FLOAT is only defined on MIPS, so it is sufficient to do
>
> ifeq ($(BR2_MIPS_SOFT_FLOAT),y)
>
> However, since this is about a glibc bug, shouldn't it check for a glibc
> toolchain as well?
Isn't the glibc bug that it allowed to use fpenv in situations where it
shouldn't have allowed it ? If that's the case, perhaps the other
libcs didn't had this bug, and fpenv really shouldn't be used with MIPS
soft-float, regardless of the C library in use ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-10 6:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 13:21 [Buildroot] [PATCH v2] poco: disable fpenvironment for MIPS without FPU yegorslists at googlemail.com
2018-10-09 20:13 ` Arnout Vandecappelle
2018-10-10 6:45 ` Thomas Petazzoni [this message]
2018-10-10 7:02 ` Yegor Yefremov
2018-10-10 7:05 ` Yegor Yefremov
2018-10-10 7:12 ` Thomas Petazzoni
2018-10-10 7:14 ` Yegor Yefremov
2018-10-10 7:45 ` Arnout Vandecappelle
2018-10-10 8:23 ` Yegor Yefremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010084502.04f1cf7e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox