[Buildroot] [PATCH 1/1] pkg-waf: add support for <pkg>_SUBDIR

[Thomas Petazzoni <thomas.petazzoni@bootlin.com>]

Hello Lionel,

Thanks for your patch, sorry for the slow reply. See some feedback
below.

On Wed, 19 Sep 2018 15:31:40 +0200, Lionel Orry wrote:
> In the Buildroot manual, it is specified that the Waf-based
> infrastructure supports the <pkg>_SUBDIR variable, which was not true.
> 
> This patch makes use of this variable by changing to the given
> sub-directory before executing waf commands.
> 
> Signed-off-by: Lionel Orry <lionel.orry@gmail.com>

First, could you update the Buildroot manual to document this new
variable of the waf package infrastructure ?

> +$(2)_SRCDIR            = $$($(2)_DIR)/$$($(2)_SUBDIR)

Could you try after dropping this line? In fact the generic package
infrastructure already defines <pkg>_SRCDIR as <pkg>_DIR/<pkg>_SUBDIR,
so it shouldn't be needed to replicate that here.

And bonus point if you submit another patch that drops those redundant
lines from pkg-cmake, pkg-meson and pkg-python, of course after testing
that it still works fine :)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com