From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2,1/8] libselinux: bump to version 2.8
Date: Thu, 11 Oct 2018 09:57:58 +0200 [thread overview]
Message-ID: <20181011095758.7beb2566@windsurf> (raw)
In-Reply-To: <CAPi7W80jBdoLui_B0UxRO1gB8mqoEi8pBbd78drTXk_8sn1EXg@mail.gmail.com>
Hello Fabrice,
On Wed, 10 Oct 2018 23:05:02 +0200, Fabrice Fontaine wrote:
> I will take the example of host-libsepol (this is the same for
> host-libselinux)
> Without this update, build of host-libsepol fails on:
> install -m 755 libsepol.so.1 /lib
> install: cannot create regular file '/lib/libsepol.so.1': Permission denied
>
> It seems that 0001-libsepol-build-follow-standard-semantics-for-DESTD.patch
> and
> https://github.com/SELinuxProject/selinux/commit/f8532f17731c82df9956aa1c92f7fb08bd65bf05
> are not exactly the same.
> Especially, it seems that LIBINSTALL = $(DESTDIR)$(LIBDIR) has not been
> added in upstream.
> upstream directly uses DESTDIR which is why I got a failure: install -m 755
> $(LIBSO) $(DESTDIR)$(SHLIBDIR)
> I don't know why there is such a difference but perhaps Marcus knows?
> If Marcus confirms that this is a mistake, I can always add a patch to fix
> this and send it upstream.
OK, I see. They want to install the libraries to /lib and not /usr/lib,
which is why they don't prefix SHLIBDIR with $(PREFIX).
So, for the host installation, I would recommend to do this:
PREFIX=$(HOST_DIR) SHLIBDIR=$(HOST_DIR)/lib
It is I believe semantically more correct than passing DESTDIR, even if
in practice it does exactly the same thing.
Also, for the target installation, why are you overriding SHLIBDIR to
be /usr/lib ? Any issue with keeping the libraries in /lib, like
upstream wants ?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-10-11 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 20:50 [Buildroot] [PATCH v2,1/8] libselinux: bump to version 2.8 Fabrice Fontaine
2018-09-21 20:50 ` [Buildroot] [PATCH v2,2/8] libsepol: " Fabrice Fontaine
2018-09-21 20:50 ` [Buildroot] [PATCH v2,3/8] libsemanage: " Fabrice Fontaine
2018-09-21 20:50 ` [Buildroot] [PATCH v2,4/8] checkpolicy: " Fabrice Fontaine
2018-09-21 20:50 ` [Buildroot] [PATCH v2,5/8] restorecond: " Fabrice Fontaine
2018-09-21 20:50 ` [Buildroot] [PATCH v2,6/8] policycoreutils: " Fabrice Fontaine
2018-09-21 20:50 ` [Buildroot] [PATCH v2,7/8] selinux-python: " Fabrice Fontaine
2018-09-21 20:50 ` [Buildroot] [PATCH v2,8/8] semodule-utils: " Fabrice Fontaine
2018-09-27 14:00 ` [Buildroot] [PATCH v2,1/8] libselinux: " Matthew Weber
2018-09-28 20:06 ` Matthew Weber
2018-10-10 19:35 ` Thomas Petazzoni
2018-10-10 21:05 ` Fabrice Fontaine
2018-10-11 7:57 ` Thomas Petazzoni [this message]
2018-10-11 14:33 ` Fabrice Fontaine
2018-10-11 14:57 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011095758.7beb2566@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox