From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] webkitgtk: explicitly set USE_GSTREAMER_GL build option
Date: Thu, 11 Oct 2018 21:23:43 +0200 [thread overview]
Message-ID: <20181011192343.GA31509@scaer> (raw)
In-Reply-To: <87in281h7o.fsf@dell.be.48ers.dk>
Peter, Arnout, All,
On 2018-10-11 20:16 +0200, Peter Korsgaard spake thusly:
> >>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> > 'imply' is syntactic sugar for 'default y if ...'. The *only* thing it changes
> > is the place where you put the imply. (To be exact, it is the same as 'default
> > ...' because it propagates the m/y/n state to the default, not just y/n. But
> > since we don't use m, it doesn't matter.)
>
> > For this specific case, it is pretty obvious that putting a 'default y if
> > BR2_PACKAGE_WEBKITGTK_MULTIMEDIA' on BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
As the submitter said "in general it is preferred due to better
performance", why don't we just have, in webkitgtk:
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL if BR2_PACKAGE_GST1_PLUGINS_BAD
Or even further:
select BR2_PACKAGE_GST1_PLUGINS_BAD
select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
Of course, that requires propagating the required dependencies...
But since webkitgtk already depends on libgtk3, which itself depends on
LIBEGL_WAYLAND or LIBGL, we're not too far off...
> > would be crazy. On the other hand, adding the imply in webkitgtk looks nice,
> > concise and clear.
Sorry, I am still not convinced that using 'imply' in Buildroot is a
good idea overall... :-(
> Exactly, which is why I suggested it to Adrian.
On the other hand, this is webkitgtk we're speaking here. It's already
huge, really huge. What would be the problem with 'select'ing
GST1_PLUGINS_BAD_PLUGIN_GL if it is known to be the 'best' solution
(even if not strictly required) ?
But I'm done speaking about it now.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-10-11 19:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 22:08 [Buildroot] [PATCH 0/4] webkitgtk: assorted fixes and improvements Adrian Perez de Castro
2018-10-09 22:08 ` [Buildroot] [PATCH 1/4] webkitgtk: move JSC JIT selection logic to kconfig Adrian Perez de Castro
2018-10-09 22:08 ` [Buildroot] [PATCH 2/4] webkitgtk: enable package for aarch64 Adrian Perez de Castro
2018-10-09 22:08 ` [Buildroot] [PATCH 3/4] webkitgtk: enable JIT support on 32-bit MIPS Adrian Perez de Castro
2018-10-09 22:08 ` [Buildroot] [PATCH 4/4] webkitgtk: explicitly set USE_GSTREAMER_GL build option Adrian Perez de Castro
2018-10-10 19:26 ` Thomas Petazzoni
2018-10-10 20:24 ` Yann E. MORIN
2018-10-11 12:39 ` Arnout Vandecappelle
2018-10-11 18:16 ` Peter Korsgaard
2018-10-11 19:23 ` Yann E. MORIN [this message]
2018-10-11 21:56 ` Arnout Vandecappelle
2018-10-19 18:25 ` Adrian Perez de Castro
2018-10-20 12:26 ` Arnout Vandecappelle
2018-10-25 0:39 ` Adrian Perez de Castro
2018-10-10 22:04 ` Arnout Vandecappelle
2018-10-11 6:43 ` Thomas Petazzoni
2018-10-11 13:48 ` Adrian Perez de Castro
2018-10-10 19:23 ` [Buildroot] [PATCH 0/4] webkitgtk: assorted fixes and improvements Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011192343.GA31509@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox