Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] sedutil: disable for MIPS Codesourcery toolchain
Date: Sat, 13 Oct 2018 22:22:24 +0200	[thread overview]
Message-ID: <20181013202225.22359-1-peter@korsgaard.com> (raw)

Fixes:
http://autobuild.buildroot.net/results/005/00588d7cd37ba9620f01e970bf328540527558fc/
http://autobuild.buildroot.net/results/2fc/2fc2d0111e467671ee4cec427234a9b2aada1cc9/

Linux 4.4 moved the NVME ioctl definitions from nvme.h to nvme_ioctl.h in
commit 9d99a8dda154 (nvme: move hardware structures out of the uapi version
of nvme.h), but nvme_ioctl.h was only exported to user space in 4.4.4 in
commit 7712c014b16f64d3 (uapi: update install list after nvme.h rename).

sedutil contains the needed logic to look at either nvme.h or nvme_ioctl.h,
but as the ioctl definitions are not exported in 4.4..4.4.3, it fails to
build.

The MIPS Codesourcery toolchain uses 4.4.1 kernel headers, so disable the
sedutil package if this toolchain is used.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/sedutil/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/sedutil/Config.in b/package/sedutil/Config.in
index fbfcf0dd54..f3452b60fb 100644
--- a/package/sedutil/Config.in
+++ b/package/sedutil/Config.in
@@ -12,6 +12,7 @@ config BR2_PACKAGE_SEDUTIL
 	depends on BR2_PACKAGE_SEDUTIL_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12 # linux/nvme.h
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # C++11
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS # 4.4.1 headers
 	depends on BR2_INSTALL_LIBSTDCPP
 	help
 	  The Drive Trust Alliance Self Encrypting Drive Utility,
@@ -22,6 +23,7 @@ config BR2_PACKAGE_SEDUTIL
 
 comment "sedutil needs a toolchain w/ C++, gcc >= 4.8, headers >= 3.12"
 	depends on BR2_PACKAGE_SEDUTIL_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_MIPS
 	depends on !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || \
 		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
-- 
2.11.0

             reply	other threads:[~2018-10-13 20:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-13 20:22 Peter Korsgaard [this message]
2018-10-14 18:04 ` [Buildroot] [PATCH] sedutil: disable for MIPS Codesourcery toolchain Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181013202225.22359-1-peter@korsgaard.com \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox