From: Adrian Perez de Castro <aperez@igalia.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] webkitgtk: add an option to control USE_GSTREAMER_GL
Date: Thu, 25 Oct 2018 03:27:38 +0300 [thread overview]
Message-ID: <20181025002738.27486-1-aperez@igalia.com> (raw)
This covers the case where GL/GLES is available (so -DENABLE_OPENGL=ON
gets passed), which makes the webkitgtk build system assume GStreamer-GL
is available, while actually it is not.
Also, providing an option to manually disable usage of GStremer-GL can
help with certain target configurations in which using OpenGL for video
handling might result in incorrect rendering.
This fixes some autobuilder failures like the following:
http://autobuild.buildroot.net/results/187796535af53ece426641ff7d88aabada281674
http://autobuild.buildroot.net/results/00c1a8ea23a99728a4f3f4478705f2383414ae41
Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
package/webkitgtk/Config.in | 15 +++++++++++++++
package/webkitgtk/webkitgtk.mk | 7 +++++++
2 files changed, 22 insertions(+)
diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
index bf0a150251..f1228892af 100644
--- a/package/webkitgtk/Config.in
+++ b/package/webkitgtk/Config.in
@@ -105,6 +105,21 @@ config BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
This option pulls in all of the required dependencies
to enable multimedia (video/audio) support.
+if BR2_PACKAGE_WEBKITGTK_MULTIMEDIA
+
+config BR2_PACKAGE_WEBKITGTK_USE_GSTREAMER_GL
+ bool "use gstreamer-gl"
+ default y
+ depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+ select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
+ help
+ Use the GStreamer GL elements for handling video content.
+ This is recommended as it improves performance of video
+ playback. In some target configurations incorrect rendering
+ might be produced, and disabling this option may help.
+
+endif
+
config BR2_PACKAGE_WEBKITGTK_WEBDRIVER
bool "WebDriver support"
help
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 39d681b1d4..1ba1cb5329 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -95,4 +95,11 @@ WEBKITGTK_CONF_OPTS += -DENABLE_WAYLAND_TARGET=ON
endif
endif
+ifeq ($(BR2_PACKAGE_WEBKITGTK_USE_GSTREAMER_GL),y)
+WEBKITGTK_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
+WEBKITGTK_DEPENDENCIES += gst1-plugins-bad
+else
+WEBKITGTK_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
+endif
+
$(eval $(cmake-package))
--
2.19.1
next reply other threads:[~2018-10-25 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 0:27 Adrian Perez de Castro [this message]
2018-10-31 9:57 ` [Buildroot] [PATCH 1/1] webkitgtk: add an option to control USE_GSTREAMER_GL Thomas Petazzoni
2018-11-14 9:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181025002738.27486-1-aperez@igalia.com \
--to=aperez@igalia.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox