From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] valgrind: fix uclibc c99 support detection
Date: Sun, 28 Oct 2018 12:16:55 +0100 [thread overview]
Message-ID: <20181028121655.2c01ecd6@gmx.net> (raw)
In-Reply-To: <20181028104450.39b76b65@windsurf>
Hello Thomas,
On Sun, 28 Oct 2018 10:44:50 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Sun, 28 Oct 2018 10:39:57 +0100, Peter Seiderer wrote:
> > Fixes [1]:
> >
> > checking for /home/peko/autobuild/instance-0/output/host/bin/powerpc-linux-gcc option to accept ISO C99... unsupported
> > configure: error: Valgrind relies on a C compiler supporting C99
> >
> > with the following in the valgrind-3.14.0/config.log:
> >
> > configure:5517: checking for .../host/bin/powerpc-linux-gcc option to accept ISO C99
> > configure:5666: .../host/bin/powerpc-linux-gcc -c -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Os -fno-stack-protector -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 conftest.c >&5
> > conftest.c:55:9: error: unknown type name 'wchar_t'
> > const wchar_t *name;
> > ^~~~~~~
> >
> > [1] http://autobuild.buildroot.net/results/b25013f785a11f07e8da3735741b96036712f42a
>
> So the autoconf test verifies that WCHAR support is available, which is
> not (the toolchain doesn't provide it), but in practice, Valgrind does
> not need WCHAR support ?
The difference in the configure.ac files is:
$ diff -u build/valgrind-3.13.0/configure.ac build/valgrind-3.14.0/configure.ac
[...]
@@ -100,6 +113,11 @@
fi
rm $tmpfile
+# Make sure we can compile in C99 mode.
+AC_PROG_CC_C99
+if test "$ac_cv_prog_cc_c99" == "no"; then
+ AC_MSG_ERROR([Valgrind relies on a C compiler supporting C99])
+fi
[...]
But the check seems to fail in case of uclibc without WCHAR support
(but valgrind compiles fine in case the check is circumvented),
maybe the same problem as for libv4l fixed with commit
'libv4l: fix uclibc-ng configure/compile' (see [2])...
Regards,
Peter
[2] https://git.buildroot.net/buildroot/commit/package/libv4l?id=f01396a158f14c53b781c35f7ff29da0bea8c8d6
>
> Best regards,
>
> Thomas
next prev parent reply other threads:[~2018-10-28 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 9:39 [Buildroot] [PATCH v1] valgrind: fix uclibc c99 support detection Peter Seiderer
2018-10-28 9:44 ` Thomas Petazzoni
2018-10-28 11:16 ` Peter Seiderer [this message]
2018-10-28 16:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181028121655.2c01ecd6@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox