Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/f2fs-tools: add host package
Date: Wed, 31 Oct 2018 22:21:28 +0100	[thread overview]
Message-ID: <20181031212128.GM28575@scaer> (raw)
In-Reply-To: <20181026200016.30856-2-grzegorz@blach.pl>

Grzegorz, All,

On 2018-10-26 22:00 +0200, Grzegorz Blach spake thusly:
> This package is useful to create f2fs filesystem during build process.

Indeed.

> Signed-off-by: Grzegorz Blach <grzegorz@blach.pl>
> ---
[--SNIP--]
> diff --git a/package/f2fs-tools/f2fs-tools.mk b/package/f2fs-tools/f2fs-tools.mk
> index 119cef35cc..7973ebf570 100644
> --- a/package/f2fs-tools/f2fs-tools.mk
> +++ b/package/f2fs-tools/f2fs-tools.mk
> @@ -9,6 +9,7 @@ F2FS_TOOLS_SITE = http://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-to
>  F2FS_TOOLS_SITE_METHOD = git
>  F2FS_TOOLS_CONF_ENV = ac_cv_file__git=no
>  F2FS_TOOLS_DEPENDENCIES = host-pkgconf util-linux
> +HOST_F2FS_TOOLS_DEPENDENCIES = host-pkgconf host-util-linux
>  # GIT version, shipped without configure
>  F2FS_TOOLS_AUTORECONF = YES
>  F2FS_TOOLS_INSTALL_STAGING = YES
> @@ -30,3 +31,4 @@ F2FS_TOOLS_CONF_OPTS += --without-blkid
>  endif

I don't think that libblkid is needed for the host variant, so we should
probably explicitly disable it. On the other hand, libblkid is always
built by host-util-linux.

Whatever yuou choose, make that explicit.

Also, we do have host-libselinux, so wyou may want to also enable that
unconditionally.

    HOST_F2FS_TOOLS_DEPENDENCIES = \
        host-libselinux \
        host-pkgconf \
        host-util-linux

    HOST_F2FS_TOOLS_CONF_OPTS = --without-blkid --with-selinux

Regards,
Yann E. MORIN.

>  $(eval $(autotools-package))
> +$(eval $(host-autotools-package))
> -- 
> 2.17.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2018-10-31 21:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-26 20:00 [Buildroot] [PATCH 0/2] Creating a sparse file in ROOTFS_F2FS_CMD Grzegorz Blach
2018-10-26 20:00 ` [Buildroot] [PATCH 1/2] package/f2fs-tools: add host package Grzegorz Blach
2018-10-31 21:21   ` Yann E. MORIN [this message]
2018-11-03 14:45     ` Thomas Petazzoni
2018-11-03 14:37   ` Thomas Petazzoni
2018-10-26 20:00 ` [Buildroot] [PATCH 2/2] fs/f2fs: add support for creating a f2fs image Grzegorz Blach
2018-10-31 21:42   ` Yann E. MORIN
2018-11-03 14:48   ` Thomas Petazzoni
2018-11-04 16:48     ` Grzegorz Blach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031212128.GM28575@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox