Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Mayer <mmayer@broadcom.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Config.in: add BR2_DL_DIR_OPTS
Date: Wed, 31 Oct 2018 14:39:30 -0700	[thread overview]
Message-ID: <20181031213930.49837-1-mmayer@broadcom.com> (raw)

Provide a simple mechanism to pass extra arguments to "mkdir" when
creating download directories. This can be helpful if one needs the
download directories to be writable multiple users ("shared download
cache").

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
 Config.in               | 14 ++++++++++++++
 package/pkg-download.mk |  2 +-
 2 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/Config.in b/Config.in
index 42cdf7a3ebdc..0442d8403b4a 100644
--- a/Config.in
+++ b/Config.in
@@ -214,6 +214,20 @@ config BR2_DL_DIR
 
 	  The default is $(TOPDIR)/dl
 
+config BR2_DL_DIR_OPTS
+	string "Options for mkdir when it creates BR2_DL_DIR"
+	default ""
+	help
+	  Specify command line options for the mkdir command when it
+	  creates BR2_DL_DIR.
+
+	  For example, this can be used to specify directory permissions
+	  (say, "-m 0775") for directories inside BR2_DL_DIR. One would
+	  want this if the download directory is a shared "cache" for
+	  multiple users, so everybody can write to these directories.
+
+	  The default empty (no additional options).
+
 config BR2_HOST_DIR
 	string "Host dir"
 	default "$(BASE_DIR)/host"
diff --git a/package/pkg-download.mk b/package/pkg-download.mk
index 73ea2a69f829..d6bfe2bb06d0 100644
--- a/package/pkg-download.mk
+++ b/package/pkg-download.mk
@@ -91,7 +91,7 @@ endif
 endif
 
 define DOWNLOAD
-	$(Q)mkdir -p $($(PKG)_DL_DIR)
+	$(Q)mkdir $(BR2_DL_DIR_OPTS) -p $($(PKG)_DL_DIR)
 	$(Q)$(EXTRA_ENV) $(FLOCK) $(DL_WRAPPER) \
 		-c '$($(PKG)_DL_VERSION)' \
 		-d '$($(PKG)_DL_DIR)' \
-- 
2.17.1

             reply	other threads:[~2018-10-31 21:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-31 21:39 Markus Mayer [this message]
2018-11-01  1:54 ` [Buildroot] [PATCH] Config.in: add BR2_DL_DIR_OPTS Carlos Santos
2018-11-01  5:18   ` Markus Mayer
2018-11-01  9:06 ` Yann E. MORIN
2018-11-01 11:01   ` Thomas Petazzoni
2018-11-01 11:18     ` Yann E. MORIN
2018-11-01 12:19 ` Arnout Vandecappelle
2018-11-01 12:23   ` Yann E. MORIN
2018-11-01 15:16     ` Markus Mayer
2018-11-01 17:04       ` Yann E. MORIN
2019-03-17 12:51 ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181031213930.49837-1-mmayer@broadcom.com \
    --to=mmayer@broadcom.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox