From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] alsa-utils: install systemd sevice files
Date: Thu, 1 Nov 2018 14:51:15 +0100 [thread overview]
Message-ID: <20181101145115.38919e8f@windsurf> (raw)
In-Reply-To: <20181030224139.5140-1-ps.report@gmx.net>
Hello,
On Tue, 30 Oct 2018 23:41:39 +0100, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
> - fix symlinks (reported by ????? ??????????)
> ---
> package/alsa-utils/alsa-utils.mk | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
So, I have applied (after fixing the typo in the commit title), but I
am not a big fan in fact. Indeed, the alsa-utils build system has all
the logic to install those service files, provided --enable-systemd is
passed.
Unfortunately, we completely override the alsa-utils "make install"
before since we define ALSA_UTILS_INSTALL_TARGET_CMDS.
Perhaps the alsa-utils package should be reworked to use
ALSA_UTILS_INSTALL_TARGET_CMDS, and then use post-install target hooks
to remove unwanted programs/data if applicable.
But since that was clearly a larger effort, I took your patch as-is as
it does the right thing considering how alsa-utils.mk works today.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-01 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 22:41 [Buildroot] [PATCH v2] alsa-utils: install systemd sevice files Peter Seiderer
2018-11-01 13:51 ` Thomas Petazzoni [this message]
2018-11-21 17:35 ` Yann E. MORIN
2018-11-21 22:03 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181101145115.38919e8f@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox