From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] support/scripts/mkmakefile: Wrapper is silent by default
Date: Fri, 2 Nov 2018 15:20:53 +0100 [thread overview]
Message-ID: <20181102142053.GC28575@scaer> (raw)
In-Reply-To: <20181102112933.14823-1-serj.kalichev@gmail.com>
Serj, All,
On 2018-11-02 14:29 +0300, Serj Kalichev spake thusly:
> Suppose we use Makefile wrapper and build some
> project out of buildroot tree (O=...). The commands like "make
> busybox-all-external-deps" will output the string "uname 022 && make ..." to
> stdout before the usefull information. It pollutes stdout. In the same time
> if we use the same command in the buildroot source-tree then we don't get the
> additional output. This patch makes wrapper silent by default. People who
> prefer to see more verbose output can use V=1.
>
> Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> support/scripts/mkmakefile | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/support/scripts/mkmakefile b/support/scripts/mkmakefile
> index 37162a3173..c7569f2ca5 100755
> --- a/support/scripts/mkmakefile
> +++ b/support/scripts/mkmakefile
> @@ -20,6 +20,13 @@ echo " GEN $2/Makefile"
> cat << EOF > $2/Makefile
> # Automatically generated by $0: don't edit
>
> +ifeq ("\$(origin V)", "command line")
> +VERBOSE := \$(V)
> +endif
> +ifneq (\$(VERBOSE),1)
> +Q := @
> +endif
> +
> lastword = \$(word \$(words \$(1)),\$(1))
> makedir := \$(dir \$(call lastword,\$(MAKEFILE_LIST)))
>
> @@ -33,7 +40,7 @@ MAKEFLAGS += --no-print-directory
> all := \$(filter-out Makefile,\$(MAKECMDGOALS))
>
> _all:
> - umask 0022 && \$(MAKE) \$(MAKEARGS) \$(all)
> + \$(Q)umask 0022 && \$(MAKE) \$(MAKEARGS) \$(all)
>
> Makefile:;
>
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-11-02 14:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 11:26 [Buildroot] [PATCH 1/1] support/scripts/mkmakefile: Silent wrapper Serj Kalichev
2018-11-01 20:44 ` Yann E. MORIN
2018-11-02 11:36 ` Serj Kalichev
2018-11-02 11:29 ` [Buildroot] [PATCH v2 1/1] support/scripts/mkmakefile: Wrapper is silent by default Serj Kalichev
2018-11-02 14:20 ` Yann E. MORIN [this message]
2018-11-02 20:29 ` Thomas Petazzoni
2018-11-14 22:26 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181102142053.GC28575@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox