Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fwts: Enable optional efi_runtime kernel module build
Date: Fri, 2 Nov 2018 19:18:12 +0100	[thread overview]
Message-ID: <20181102191812.114ce345@windsurf> (raw)
In-Reply-To: <1541162207-8770-1-git-send-email-sumit.garg@linaro.org>

Hello,

On Fri,  2 Nov 2018 18:06:47 +0530, Sumit Garg wrote:
> Firmware test suite does provides efi_runtime kernel module required
> to run UEFI tests. So optionally enable this module build.
> 
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> ---
>  package/fwts/Config.in | 8 ++++++++
>  package/fwts/fwts.mk   | 6 ++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/package/fwts/Config.in b/package/fwts/Config.in
> index 959d871..3ddb989 100644
> --- a/package/fwts/Config.in
> +++ b/package/fwts/Config.in
> @@ -28,3 +28,11 @@ comment "fwts needs a glibc toolchain w/ wchar, threads"
>  	depends on BR2_USE_MMU
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || \
>  		!BR2_TOOLCHAIN_USES_GLIBC
> +
> +config BR2_PACKAGE_FWTS_EFI_RUNTIME_MODULE
> +	bool "efi_runtime_module"
> +	depends on BR2_PACKAGE_FWTS
> +	depends on BR2_LINUX_KERNEL
> +	help
> +	  Firmware Test Suite (FWTS) also provides EFI runtime kernel
> +	  module required to run UEFI tests.

In addition to the other comments being made: when there is a "depends
on BR2_LINUX_KERNEL", we typically need add something like this:

comment "efi-runtime module needs a Linux kernel to be built"
	depends on !BR2_LINUX_KERNEL

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-11-02 18:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02 12:36 [Buildroot] [PATCH 1/1] fwts: Enable optional efi_runtime kernel module build Sumit Garg
2018-11-02 13:57 ` Erico Nunes
2018-11-02 14:19   ` Yann E. MORIN
2018-11-05  4:15     ` Sumit Garg
2018-11-02 18:18 ` Thomas Petazzoni [this message]
2018-11-05  4:16   ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181102191812.114ce345@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox