Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] llvm: fix build of host-llvm
Date: Sat, 3 Nov 2018 15:35:59 +0100	[thread overview]
Message-ID: <20181103153559.43c5277e@windsurf> (raw)
In-Reply-To: <83cfc6de-40c3-9c92-1f6e-fcc0bf13ff4e@gmail.com>

Hello,

On Sat, 3 Nov 2018 15:15:30 +0100, Romain Naour wrote:

> > @@ -10,6 +10,7 @@ config BR2_PACKAGE_LLVM_TARGET_ARCH
> >  	default "AArch64" if BR2_aarch64
> >  	default "ARM" if BR2_arm || BR2_armeb
> >  	default "X86" if BR2_i386 || BR2_x86_64
> > +	default "host"  
> 
> I'm not sure this is the correct thing to do since BR2_PACKAGE_LLVM_TARGET_ARCH
> will be used for the target variant.
> 
> "host" stand for "automatic detection"
> 
> Maybe you want to add "X86" along with LLVM_TARGETS_TO_BUILD for host-llvm ?
> 
> Something like:
> 
> HOST_LLVM_TARGETS_TO_BUILD = $(LLVM_TARGETS_TO_BUILD) X86

For the host, it makes sense to use "automatic detection", so what
about:

HOST_LLVM_TARGETS_TO_BUILD = $(LLVM_TARGETS_TO_BUILD) host

i.e, have support for the target architecture, but also the
architecture ?

However, presumably, LLVM may not have support for all host
architectures, so this calls for a BR2_PACKAGE_HOST_LLVM_ARCH_SUPPORTS ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-03 14:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-03 12:27 [Buildroot] [PATCH 1/4] llvm: fix build of host-llvm Fabrice Fontaine
2018-11-03 12:27 ` [Buildroot] [PATCH 2/4] llvm: enable bpf Fabrice Fontaine
2018-11-03 13:14   ` Thomas Petazzoni
2018-11-03 14:14     ` Fabrice Fontaine
2018-11-03 14:24       ` Valentin Korenblit
2018-11-03 14:45         ` Fabrice Fontaine
2018-11-03 12:27 ` [Buildroot] [PATCH 3/4] libv4l: add elfutils optional dependency Fabrice Fontaine
2018-11-03 13:18   ` Thomas Petazzoni
2018-11-03 14:06     ` Fabrice Fontaine
2018-11-03 12:27 ` [Buildroot] [PATCH 4/4] scripts/check-bin-arch: fix failure with bpf Fabrice Fontaine
2018-11-03 13:20   ` Thomas Petazzoni
2018-11-03 13:53     ` Fabrice Fontaine
2018-11-03 14:00       ` Thomas Petazzoni
2018-11-03 14:15 ` [Buildroot] [PATCH 1/4] llvm: fix build of host-llvm Romain Naour
2018-11-03 14:35   ` Thomas Petazzoni [this message]
2018-11-03 15:11     ` Fabrice Fontaine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181103153559.43c5277e@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox