From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Sun, 4 Nov 2018 11:19:53 +0100 Subject: [Buildroot] [PATCH 1/2] ngrep: bump to version 1.47 In-Reply-To: References: <20181101132326.13015-1-fontaine.fabrice@gmail.com> <20181103224222.229c064a@windsurf> Message-ID: <20181104111953.08d765e0@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Sat, 3 Nov 2018 23:01:07 +0100, Fabrice Fontaine wrote: > > So PCRE is not mandatory. > Indeed, PCRE is not really "mandatory", ngrep use GNU regex by default > but this was already the case before the bump (in version 1.45): see > https://github.com/jpr5/ngrep/blob/V1_45/configure.in. > I didn't want to change this behavior when bumping the package and I > could find why pcre wasn't made optional in the initial commit back in > 2011. > However, I'll add a third patch in my serie to make pcre an optional > dependency before bumping the package.. Indeed, it could be a third patch. > > > @@ -20,7 +20,6 @@ NGREP_CONF_ENV += LIBS+="$(NGREP_LIBS)" > > > > This assignment becomes totally pointless. > OK, I'll replace it by: > ifeq ($(BR2_STATIC_LIBS),y) > NGREP_CONF_ENV += LIBS="$(STAGING_DIR)/usr/bin/pcap-config --static > --additional-libs" > endif Sorry, my bad here, I had entirely missed that NGREP_LIBS was still being set in the BR2_STATIC_LIBS case. So the way you did it originally was OK, sorry about that. Doing is directly in NGREP_CONF_ENV also works, since there will be a single assignment of LIBS. > > You should add a --disable-tcpkill here, and then in your PATCH 2/2, > > add the optional dependency on libdnet. > OK, I'll make a v2 with this update (and the other ones) Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com