Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] picotts: new package
Date: Mon, 5 Nov 2018 09:26:37 +0100	[thread overview]
Message-ID: <20181105092637.2623858e@windsurf> (raw)
In-Reply-To: <1e8836fe-f499-1067-c2a0-9c7e0821af6a@fanamoel.com>

Hello,

On Mon, 5 Nov 2018 08:52:02 +0100, I?igo Huguet wrote:

> The problem is that there is no upstream anywhere. This program source 
> was "extracted" from Android source, but there is not any "official" 
> team maintaining it. Actually, I got the source code from Ubuntu's 
> package and uploaded it to my own github.

Meh, Android is really wonderful open-source :-)

> About the scripts being use case specific, I think they're not. The 
> program only can create a .wav file, so if you want to use it to make 
> "on the fly" speech, you need to create a temporary wav, play it, and 
> delete it. This is in fact what the helper scripts do.
> 
> I you think they must be removed I will do it, please tell me exactly 
> what to do. Or, since the repository from which the package download the 
> program is mine, I can include them to my repo directly.

Yes, it would be nicer if you included them directly in your repo.

An example of something that was not completely correct is that your
script uses aplay, but the package does not select
BR2_PACAKAGE_ALSA_UTILS. But I believe it should not: there are
possible use cases for this text-to-speech engine that don't involve
playing the sound on the local device.

> > Please add a blank line, and then the upstream URL of the project.  
> 
> Same problem, there is not any upstream URL.

Just put the Github URL then :)

> It will work if I just add those packages as dependencies?

Yes, but we very much prefer to use <pkg>_AUTORECONF = YES when
possible.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-11-05  8:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  8:25 [Buildroot] [PATCH 1/1] picotts: new package Iñigo Huguet
2018-11-02 21:11 ` Thomas Petazzoni
2018-11-05  7:52   ` Iñigo Huguet
2018-11-05  8:26     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105092637.2623858e@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox