Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/libnfs: bump to version 3.0.0
Date: Mon, 5 Nov 2018 14:04:05 +0100	[thread overview]
Message-ID: <20181105140405.34c18334@windsurf> (raw)
In-Reply-To: <739c919b58c42b5a314bd9877f0f1c7a38d8daf7.camel@embedded.rocks>

Hello,

On Mon, 05 Nov 2018 12:09:04 +0100, J?rg Krause wrote:
> On Mon, 2018-11-05 at 09:17 +0100, Thomas Petazzoni wrote:
> > Hello,
> > 
> > On Mon,  5 Nov 2018 07:27:05 +0100, J?rg Krause wrote:  
> > > Also add an patch from upstream to fix building libnfs with the musl C
> > > library. This issue was introduced upstream between version 2.0.0 and
> > > version 3.0.0.
> > > 
> > > Note, that upstreams commit message says it fixes a warning. However, as
> > > musl is more strictly regarding missing headers it actually fixes the
> > > build with musl.
> > > 
> > > Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> > > ---
> > > v1 -> v2:
> > >  - fix hash of license file COPYING  
> > 
> > What are the changes in the COPYING file ?  
> 
> I contains a clarification about the .x files being destributed under
> the simplified BSD licence.
> 
> We already note in LIBNFS_LICENSE that the .x files are BSD-2-Clause.
> 
> Shall I send a v3?

When the hash of a license file changes, it is always good to explain
briefly in the commit log what changed, as it makes it clear that you
have paid attention at the changes and it was not just "let's update
the hash to whatever it needs to be to make legal-info happy" :-)

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-11-05 13:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  6:27 [Buildroot] [PATCH v2] package/libnfs: bump to version 3.0.0 Jörg Krause
2018-11-05  8:17 ` Thomas Petazzoni
2018-11-05 11:09   ` Jörg Krause
2018-11-05 13:04     ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105140405.34c18334@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox