From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/linux-tools: add support for pcitest tool
Date: Fri, 9 Nov 2018 22:14:54 +0100 [thread overview]
Message-ID: <20181109221454.1329d46e@windsurf> (raw)
In-Reply-To: <676a63fc4e656a81398dc1fca048f3e2bdea327e.1541701306.git.gustavo.pimentel@synopsys.com>
Hello Gustavo,
Thanks for this contribution, however, I have a question below.
On Thu, 8 Nov 2018 19:22:30 +0100, Gustavo Pimentel wrote:
> +define PCI_BUILD_CMDS
> + $(Q)if ! grep install $(LINUX_DIR)/tools/pci/Makefile >/dev/null 2>&1 ; then \
> + echo "Your kernel version is too old and does not have install section in the pci tools." ; \
> + echo "At least kernel 4.7 must be used." ; \
I tried building with 4.18, but still ran into this error. Indeed, it's
only in 4.19 that your patch
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/tools/pci?id=1ce78ce09430a5ffb987015ab2e24d145690b9a3
was added, which adds the Makefile.
So, either you fallback to building pcitest.c manually if there is no
Makefile, or the error message should be updated to say "At least
kernel 4.19 must be used".
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-09 21:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 18:22 [Buildroot] [PATCH] package/linux-tools: add support for pcitest tool Gustavo Pimentel
2018-11-09 21:14 ` Thomas Petazzoni [this message]
2018-11-09 21:39 ` Arnout Vandecappelle
2018-11-13 1:59 ` Gustavo Pimentel
2018-11-13 1:18 ` Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181109221454.1329d46e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox