Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] libkrb5: fix build on riscv
Date: Sun, 11 Nov 2018 20:53:43 +0100	[thread overview]
Message-ID: <20181111205343.76b10bff@windsurf.home> (raw)
In-Reply-To: <20181111175210.14031-1-fontaine.fabrice@gmail.com>

Hello,

On Sun, 11 Nov 2018 18:52:10 +0100, Fabrice Fontaine wrote:
> Define _REENTRANT otherwise pthread detection will fail
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/39a51d0c3feab74edd8a17c9174d031ccc7ffe1d
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/libkrb5/libkrb5.mk | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/package/libkrb5/libkrb5.mk b/package/libkrb5/libkrb5.mk
> index d9d7160ae8..6534c069ee 100644
> --- a/package/libkrb5/libkrb5.mk
> +++ b/package/libkrb5/libkrb5.mk
> @@ -52,7 +52,14 @@ else
>  LIBKRB5_CONF_OPTS += --without-readline
>  endif
>  
> -ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +ifeq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
> +# gcc on riscv doesn't define _REENTRANT when -pthread is passed while
> +# it should. Compensate this deficiency here otherwise libkrb5 configure
> +# script doesn't find that thread support is enabled.
> +ifeq ($(BR2_riscv),y)
> +LIBKRB5_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D_REENTRANT"
> +endif

You did a similar change in libmicrothttpd, for which the same fix was
already done for ARC. Any idea why libmicrohttpd needs this hack for
both ARC and RISC-V, while libkrb5 would need it only for RISC-V ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-11 19:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-11 17:52 [Buildroot] [PATCH 1/1] libkrb5: fix build on riscv Fabrice Fontaine
2018-11-11 19:53 ` Thomas Petazzoni [this message]
2018-11-11 20:15   ` Fabrice Fontaine
2018-11-11 20:31     ` Thomas Petazzoni
2018-11-11 20:39       ` Fabrice Fontaine
2018-11-11 21:08         ` Thomas Petazzoni
2018-11-11 21:10 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181111205343.76b10bff@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox