Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] fs: Add common rootfs dependencies to PACKAGES
Date: Tue, 13 Nov 2018 15:51:02 +0100	[thread overview]
Message-ID: <20181113155102.4f977baa@windsurf> (raw)
In-Reply-To: <20181108130417.1277-2-anaumann@ultratronik.de>

Hello Andres,

On Thu,  8 Nov 2018 14:04:16 +0100, Andreas Naumann wrote:

> diff --git a/fs/common.mk b/fs/common.mk
> index 2a5a202a89..a4a178c88a 100644
> --- a/fs/common.mk
> +++ b/fs/common.mk
> @@ -65,6 +65,7 @@ ROOTFS_COMMON_DEPENDENCIES = \
>  	host-fakeroot host-makedevs \
>  	$(BR2_TAR_HOST_DEPENDENCY) \
>  	$(if $(PACKAGES_USERS)$(ROOTFS_USERS_TABLES),host-mkpasswd)
> +PACKAGES += $(ROOTFS_COMMON_DEPENDENCIES)

Thanks a lot for testing the PPSH stuff and providing some bug fixes!

I've integrated into my patch series the following change:

@@ -171,7 +172,7 @@ rootfs-$(1): $$(BINARIES_DIR)/rootfs.$(1)
 
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)),y)
 TARGETS_ROOTFS += rootfs-$(1)
-PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES))
+PACKAGES += $$(filter-out rootfs-%,$$(ROOTFS_$(2)_DEPENDENCIES)) $(ROOTFS_COMMON_DEPENDENCIES)
 endif
 
 # Check for legacy POST_TARGETS rules

which addresses this problem, while adding the dependencies only when a
filesystem image is selected. Having duplicates in PACKAGES is not a
problem.

I hope to send a v4 of my series soon.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-11-13 14:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 13:04 [Buildroot] [PATCH 0/2] Preparation for per-package host/target Andreas Naumann
2018-11-08 13:04 ` [Buildroot] [PATCH 1/2] fs: Add common rootfs dependencies to PACKAGES Andreas Naumann
2018-11-09 22:11   ` Arnout Vandecappelle
2018-11-12 12:53     ` Andreas Naumann
2018-11-12 16:46       ` Yann E. MORIN
2018-11-12 17:32         ` Arnout Vandecappelle
2018-11-12 17:44           ` Yann E. MORIN
2018-11-13 14:51   ` Thomas Petazzoni [this message]
2018-11-13 15:30     ` Andreas Naumann
2018-11-08 13:04 ` [Buildroot] [PATCH 2/2] linux: Make dtc install step more reliable Andreas Naumann
2018-11-09 22:14   ` Arnout Vandecappelle
2018-11-12 12:55     ` Andreas Naumann
2018-11-12 13:59       ` Arnout Vandecappelle
2018-11-08 13:23 ` [Buildroot] [PATCH 0/2] Preparation for per-package host/target Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181113155102.4f977baa@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox