From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order
Date: Thu, 15 Nov 2018 17:49:56 +0100 [thread overview]
Message-ID: <20181115164956.GK10271@scaer> (raw)
In-Reply-To: <20181115163520.GJ10271@scaer>
Serj, All,
On 2018-11-15 17:35 +0100, Yann E. MORIN spake thusly:
> On 2018-11-15 18:25 +0300, Serj Kalichev spake thusly:
> > The command "make show-build-order" doesn't show dependencies of rootfs-common target.
> >
> > This patch adds $(ROOTFS_COMMON_DEPENDENCIES) to PACKAGES variable.
> >
> > Signed-off-by: Serj Kalichev <serj.kalichev@gmail.com>
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> (I would still have preferred they be added to the _DEPENDENCIES list,
> but others disagreed, so...)
I somehow got confused to see that patch pop up on the list, wen Thomas
said he had integrated it in his PPS series.
It turns out that the previous thread was started by Andreas:
http://lists.busybox.net/pipermail/buildroot/2018-November/thread.html#235256
This patch by Serj confused me because the reason for that same change
is totally different (but as valid).
My Reviewed-by tag still stands, obviously.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2018-11-15 16:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 15:25 [Buildroot] [PATCH 1/1] fs/common.mk: Fix show-build-order Serj Kalichev
2018-11-15 16:35 ` Yann E. MORIN
2018-11-15 16:49 ` Yann E. MORIN [this message]
2018-11-18 9:01 ` Peter Korsgaard
2018-11-26 11:49 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181115164956.GK10271@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox