From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] gstreamer: fix build on riscv
Date: Sat, 17 Nov 2018 23:19:14 +0100 [thread overview]
Message-ID: <20181117231914.6600b731@gmx.net> (raw)
In-Reply-To: <20181117184533.21169-1-fontaine.fabrice@gmail.com>
Hello Fabrice,
On Sat, 17 Nov 2018 19:45:33 +0100, Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> RISC-V supports unaligned accesses, but these might run extremely slowly
> depending on the implementation so set as_cv_unaligned_access to no on
> this architecture, see:
> https://gitlab.freedesktop.org/gstreamer/gstreamer/commit/8a156d1725ecd03f2e8cdc8874e081dda2d3b43d
>
> Fixes:
> - http://autobuild.buildroot.org/results/dca32c929350311fca1a85e251d318b43c4a3177
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/gstreamer/gstreamer/gstreamer.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/gstreamer/gstreamer/gstreamer.mk b/package/gstreamer/gstreamer/gstreamer.mk
> index 88cc798828..2ec360c94d 100644
> --- a/package/gstreamer/gstreamer/gstreamer.mk
> +++ b/package/gstreamer/gstreamer/gstreamer.mk
> @@ -15,7 +15,7 @@ GSTREAMER_LICENSE_FILES = COPYING
> # Checking if unaligned memory access works correctly cannot be done when cross
> # compiling. For the following architectures there is no information available
> # in the configure script.
> -ifeq ($(BR2_arc)$(BR2_xtensa)$(BR2_microblaze)$(BR2_nios2)$(BR2_or1k),y)
> +ifeq ($(BR2_arc)$(BR2_xtensa)$(BR2_microblaze)$(BR2_nios2)$(BR2_or1k)$(BR2_riscv),y)
> GSTREAMER_CONF_ENV = as_cv_unaligned_access=no
> endif
> ifeq ($(BR2_aarch64)$(BR2_aarch64_be),y)
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
next prev parent reply other threads:[~2018-11-17 22:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 18:45 [Buildroot] [PATCH 1/1] gstreamer: fix build on riscv Fabrice Fontaine
2018-11-17 22:19 ` Peter Seiderer [this message]
2018-11-18 7:36 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181117231914.6600b731@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox