From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next 1/2] package/pkg-luarocks: drop flock at installation time
Date: Mon, 19 Nov 2018 11:32:26 +0100 [thread overview]
Message-ID: <20181119103227.24726-2-thomas.petazzoni@bootlin.com> (raw)
In-Reply-To: <20181119103227.24726-1-thomas.petazzoni@bootlin.com>
In commit 22b327fc743b48a33aec0a9190bd67118641b294 ("pkg-luarocks: fix
top-level parallel makefile support"), a flock on $(TARGET_DIR) was
added to ensure that two Luarocks packages are not installed at the
same time.
However, to support top-level parallel build, we have now clearly
decided that per-package folders is a requirement. Therefore,
TARGET_DIR is anyway going to be different for each package, making
this flock unnecessary.
Trying to use top-level parallel build without per-package folder is
simply not supported, so this commit drops the unnecessary flock.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/pkg-luarocks.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-luarocks.mk b/package/pkg-luarocks.mk
index 29c5e66cd1..f0985433b7 100644
--- a/package/pkg-luarocks.mk
+++ b/package/pkg-luarocks.mk
@@ -63,7 +63,7 @@ endif
#
ifndef $(2)_INSTALL_TARGET_CMDS
define $(2)_INSTALL_TARGET_CMDS
- cd $$($(2)_SRCDIR) && $$(LUAROCKS_RUN_ENV) flock $$(TARGET_DIR) \
+ cd $$($(2)_SRCDIR) && $$(LUAROCKS_RUN_ENV) \
$$(LUAROCKS_RUN_CMD) make --keep $$($(2)_ROCKSPEC) $$($(2)_BUILD_OPTS)
endef
endif
--
2.19.1
next prev parent reply other threads:[~2018-11-19 10:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:32 [Buildroot] [PATCH next 0/2] Adjust Luarocks support to per-package folder Thomas Petazzoni
2018-11-19 10:32 ` Thomas Petazzoni [this message]
2018-11-19 20:28 ` [Buildroot] [PATCH next 1/2] package/pkg-luarocks: drop flock at installation time François Perrad
2018-11-19 20:46 ` Thomas Petazzoni
2018-11-19 10:32 ` [Buildroot] [PATCH next 2/2] package/luarocks: rework configuration file for per-package folders Thomas Petazzoni
2018-11-19 20:57 ` François Perrad
2018-11-20 11:02 ` Thomas Petazzoni
2018-11-21 8:23 ` François Perrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119103227.24726-2-thomas.petazzoni@bootlin.com \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox