From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] libtirpc: Fix whitespace on 4th patch
Date: Mon, 19 Nov 2018 22:10:26 +0100 [thread overview]
Message-ID: <20181119221026.7a21f37b@windsurf.home> (raw)
In-Reply-To: <20181117194856.29604-2-petr.vorel@gmail.com>
Hello,
On Sat, 17 Nov 2018 20:48:56 +0100, Petr Vorel wrote:
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
> Should be the same as v1.
> ---
> ...es-needed-to-build-rpcbind-on-top-of.patch | 78 +++++++++----------
> 1 file changed, 38 insertions(+), 40 deletions(-)
>
> diff --git a/package/libtirpc/0004-Add-more-XDR-files-needed-to-build-rpcbind-on-top-of.patch b/package/libtirpc/0004-Add-more-XDR-files-needed-to-build-rpcbind-on-top-of.patch
> index 7f53ffca16..797fb7a42c 100644
> --- a/package/libtirpc/0004-Add-more-XDR-files-needed-to-build-rpcbind-on-top-of.patch
> +++ b/package/libtirpc/0004-Add-more-XDR-files-needed-to-build-rpcbind-on-top-of.patch
> @@ -22,16 +22,16 @@ index aa5908e..4999066 100644
> +++ b/Makefile.am
> @@ -2,6 +2,9 @@ SUBDIRS = src man doc rpcgen
> ACLOCAL_AMFLAGS = -I m4
> -
> +
These are additional changes, i.e you are removing whitespace that is
here in the original source code.
> GENFILES = tirpc/rpcsvc/crypt.h \
> + tirpc/rpcsvc/mount.h \
> + tirpc/rpcsvc/nfs_prot.h \
> + tirpc/rpcsvc/rquota.h \
> tirpc/rpc/rpcb_prot.h
> -
> +
Ditto.
> noinst_HEADERS = tirpc/reentrant.h \
> @@ -11,6 +14,9 @@ noinst_HEADERS = tirpc/reentrant.h \
> -
> +
Ditto.
I.e, in the Makefile.am, our patch is not adding any more trailing
whitespace.
Then, in the .x files, those are copy/pasted from I don't remember
which project. I'm not sure how much sense it makes to fix trailing
whitespace in those patches.
Instead, it would be tremendously more useful to work with libtirpc
upstream to get all of those patches merged. I think I tried to do so a
number of years ago, but without much luck.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-19 21:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-17 19:48 [Buildroot] [PATCH 1/2] libtirpc: Bump to version 1.1.4 Petr Vorel
2018-11-17 19:48 ` [Buildroot] [PATCH 2/2] libtirpc: Fix whitespace on 4th patch Petr Vorel
2018-11-19 21:10 ` Thomas Petazzoni [this message]
2018-11-17 19:51 ` [Buildroot] [PATCH 1/2] libtirpc: Bump to version 1.1.4 Petr Vorel
2018-11-19 21:08 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2018-11-16 17:12 Petr Vorel
2018-11-16 17:12 ` [Buildroot] [PATCH 2/2] libtirpc: Fix whitespace on 4th patch Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119221026.7a21f37b@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox