Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4 v2] core/download: drop the SSH command
Date: Mon, 19 Nov 2018 22:11:45 +0100	[thread overview]
Message-ID: <20181119221145.3920ef06@windsurf.home> (raw)
In-Reply-To: <3112a0a19120c6af84b83833aa09014a3dd95fb5.1542474939.git.yann.morin.1998@free.fr>

Hello,

On Sat, 17 Nov 2018 18:15:48 +0100, Yann E. MORIN wrote:
> The ssh command was added back in 2011 with commit c61788f09 (GENTARGETS:
> add support for scp://) and was used to check that the remote file
> existed, back when we supported 'make source-check'.
> 
> However, in 2017, with commit bf28a165d (pkg-{download, generic}: remove
> source-check), we actually removed support for source-check.
> 
> The SSH command however was not removed then, and stuck, even though
> nothing ever uses it It is not even exported in the environment, and scp
> does not use it either (it has -S to specify an ssh-compatible program).
> 
> Get rid of it.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> ---
>  Config.in               | 4 ----
>  package/pkg-download.mk | 1 -
>  2 files changed, 5 deletions(-)

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-19 21:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-17 17:15 [Buildroot] [PATCH 0/4 v2] core: add host-gzip for cvs/git/svn backends Yann E. MORIN
2018-11-17 17:15 ` [Buildroot] [PATCH 1/4 v2] core/download: drop the SSH command Yann E. MORIN
2018-11-19 21:11   ` Thomas Petazzoni [this message]
2018-11-17 17:15 ` [Buildroot] [PATCH 2/4 v2] support/dependencies: treat BSD-tar like the other cases Yann E. MORIN
2018-11-17 17:15 ` [Buildroot] [PATCH 3/4 v2] package/gzip: add host variant Yann E. MORIN
2018-11-17 17:15 ` [Buildroot] [PATCH 4/4 v2] support/dependencies: add a check for a suitable gzip Yann E. MORIN
2018-11-17 17:23   ` Matthew Weber
2018-11-18 13:44     ` Yann E. MORIN
2018-11-18 14:41       ` Matthew Weber
2018-11-25  8:21         ` Peter Korsgaard
2018-11-24 14:46 ` [Buildroot] [PATCH 0/4 v2] core: add host-gzip for cvs/git/svn backends Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181119221145.3920ef06@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox