From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/luv: add patch to fix build issue with luvi
Date: Mon, 19 Nov 2018 22:24:14 +0100 [thread overview]
Message-ID: <20181119222414.487973bb@windsurf.home> (raw)
In-Reply-To: <20181115192846.18380-1-joerg.krause@embedded.rocks>
Hello,
On Thu, 15 Nov 2018 20:28:45 +0100, J?rg Krause wrote:
> Add a patch to fix a build issue with luvi after bumping luv from
> version 1.9.1 to 1.22.0.
>
> The problem is that luv now uses lua-compat-5.3 instead of defining the
> Lua 5.3 API itself. Unfortunately, luv.h now includes compat-5.3.h in the
> header file, which causes the build issue with luvi, as luvi does not
> find this local header file. Note, that luv ships lua-compat-5.3 as a
> dependency.
>
> Therefore, the patch includes compat-5.3.h in the source file luv.c, so
> it isn't exposed to external programs.
>
> Fixes:
> http://autobuild.buildroot.net/results/2244cd30986aff29b763fb7183f6fc27a82bd7fa
> http://autobuild.buildroot.net/results/01938f7f018dc69d564c22489933647b1daf62f3
> http://autobuild.buildroot.net/results/8217e863c2776d299cb90b90f1a2ed8233ec82ba
> .. and many more
>
> Note, that fixing this issue reveals another issue in luvi, which is
> fixed by the follow up patch.
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
> ...lude-compat-5.3.h-in-luv-header-file.patch | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 package/luv/0001-Do-not-include-compat-5.3.h-in-luv-header-file.patch
Series applied to master. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-19 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 19:28 [Buildroot] [PATCH 1/2] package/luv: add patch to fix build issue with luvi Jörg Krause
2018-11-15 19:28 ` [Buildroot] [PATCH 2/2] package/luvi: add patch to fix build issue Jörg Krause
2018-11-19 21:24 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181119222414.487973bb@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox