From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Tue, 20 Nov 2018 11:29:00 +0100 Subject: [Buildroot] [PATCH next v4 6/6] core: implement per-package SDK and target In-Reply-To: <7f195412-448e-400f-0ba6-d710246c7656@mind.be> References: <20181114105557.12599-1-thomas.petazzoni@bootlin.com> <20181114105557.12599-7-thomas.petazzoni@bootlin.com> <20181116144735.19585727@windsurf> <20181116195741.GV10271@scaer> <10c54101-3264-eefb-58d0-4770ef723717@mind.be> <20181119114806.4fb9d98b@windsurf.home> <20181119194905.GC2601@scaer> <7f195412-448e-400f-0ba6-d710246c7656@mind.be> Message-ID: <20181120112900.747747c8@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Hello, On Tue, 20 Nov 2018 11:22:00 +0100, Arnout Vandecappelle wrote: > >> I personally find it OK, even though it's a bit annoying to introduce > >> yet another step just for the sake of pkg-kconfig. > > Me too. And I'm not even sure if it really solves the pkg-kconfig problem. I > have a hard time remembering what all the issues were there. > > Perhaps, though, we should have a more general strategy of a per-infra > definition of what the steps are, instead of having a fixed sequence of steps. > I.e., have a pattern that should be followed by an infra-specific step to make > sure things are done correctly. So, for the kconfig case we would have an extra > kconfig_fixup step (we already have the stamp file, but it's not a real step > with hooks and the KCONFIG_DEPENDENCIES were strapped on as an afterthought), > and for the autoreconf case we would have an extra autoreconf step (instead of a > hook). And so those "injected" steps should take care of preparing the per-package folder with whatever dependencies they need ? This is probably something that can be done to fix the pkg-kconfig stuff without having to create a new "prepare" step in the generic infrastructure. > But the problem is, for pkg-kconfig, we actually need the prepare stuff to be > done in the build directory, not the source directory... So it *still* doesn't > match. Right. > > above, because autoreconf will also require the same dependencies as the > > configure step. > > ... not because of this. Most dependencies are only really needed in the > configure step, it's only some of them (host-automake etc. obviously, but also > host-autoconf-archive and host-pkg-config for the .m4 files) that are needed for > the autoreconf. So if it is split, we would need to move some dependencies to > _PREPARE_DEPENDENCIES. At this point, I don't want to change anything for autoreconf. It is part of the configure step, it works as it is. I'd like to fix just the pkg-kconfig situation. I'll try to do that within pkg-kconfig.mk. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com