From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 1/1] sdl2: fix build with --disable-threads
Date: Fri, 23 Nov 2018 22:02:04 +0100 [thread overview]
Message-ID: <20181123220204.26d38eb5@windsurf> (raw)
In-Reply-To: <20181121220923.24849-1-fontaine.fabrice@gmail.com>
Hello,
On Wed, 21 Nov 2018 23:09:23 +0100, Fabrice Fontaine wrote:
> SDL_LinuxSetThreadPriority() has been added since version 2.0.9 and
> https://github.com/SDL-mirror/SDL/commit/f25a7fa870bdceb339e5105973f689606bcb9086
>
> However, this function is used in src/dynapi/SDL_dynapi_procs.h even
> when SDL_THREADS_DISABLED
>
> However, when SDL_THREADS_DISABLED is set, SDL_LinuxSetThreadPriority is
> not defined because thread/pthread/SDL_systhread.c is not built
>
> So check SDL_THREADS_DISABLED in addition to __LINUX__
>
> Fixes:
> - http://autobuild.buildroot.org/results/539cb9ab6c605dc6be73ebe90debab1a998f2451
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> .../0001-fix-build-with-disable-threads.patch | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 package/sdl2/0001-fix-build-with-disable-threads.patch
I like how the inverted SDL_THREADS_DISABLED macro makes the code
readable. !SDL_THREADS_DISABLED means thread support is enabled...
But anyway, that's not your fault, that's how the existing SDL2 code
is. So applied to next, thanks! Please make sure you submit this
upstream.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-23 21:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-21 22:09 [Buildroot] [PATCH/next 1/1] sdl2: fix build with --disable-threads Fabrice Fontaine
2018-11-23 21:02 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181123220204.26d38eb5@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox