Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] support/graph-depends: fix package names starting with a non-char
Date: Sat, 24 Nov 2018 11:00:06 +0100	[thread overview]
Message-ID: <20181124110006.76144259@windsurf> (raw)
In-Reply-To: <20181124093452.12350-1-yann.morin.1998@free.fr>

Hello,

On Sat, 24 Nov 2018 10:34:52 +0100, Yann E. MORIN wrote:
> Graphviz' dot utility does not like nodes which names does not start
> with an ^[[:alpha:]], i.e. 18xx-ti-utils would cause grievance:
> 
>     Warning: syntax ambiguity - badly delimited number '18x' in line 4 [...]/graph-depends.dot splits into two tokens
>     Warning: syntax ambiguity - badly delimited number '18x' in line 5 [...]/graph-depends.dot splits into two tokens
>     Warning: syntax ambiguity - badly delimited number '18x' in line 6 [...]/graph-depends.dot splits into two tokens
>     Warning: syntax ambiguity - badly delimited number '18x' in line 7 [...]/graph-depends.dot splits into two tokens
> 
> Prefix nodes with an underscore to fix that.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  support/scripts/graph-depends | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Applied to master after changing "non-char" to "non-alpha" in the
commit title. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-24 10:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24  9:34 [Buildroot] [PATCH] support/graph-depends: fix package names starting with a non-char Yann E. MORIN
2018-11-24 10:00 ` Thomas Petazzoni [this message]
2018-11-26 17:50 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181124110006.76144259@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox