From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next v3 5/8] support/testing: add perl-libwww-perl test
Date: Sat, 24 Nov 2018 11:06:08 +0100 [thread overview]
Message-ID: <20181124110608.681120b2@windsurf> (raw)
In-Reply-To: <20181124090723.14722-6-francois.perrad@gadz.org>
Hello Fran?ois,
Thanks a lot for this work on adding tests for Perl packages. It is
really great to see the testing infrastructure being used more widely.
A few questions below.
On Sat, 24 Nov 2018 10:07:19 +0100, Francois Perrad wrote:
> +class TestPerllibwwwperl(TestPerlBase):
> + """
> + package:
> + libwww-perl
> + direct dependencies:
> + Encode-Locale
> + File-Listing
> + HTML-Parser
> + HTTP-Cookies
> + HTTP-Daemon
> + HTTP-Date
> + HTTP-Message
> + HTTP-Negotiate
> + LWP-MediaTypes
> + Net-HTTP
> + Try-Tiny
> + URI
> + WWW-RobotRules
> + indirect dependencies:
> + HTML-Tagset
> + IO-HTML
> + """
Sorry if I haven't followed the previous discussion, but why do we have
this docstring ? Is it just for information ?
> + config = TestPerlBase.config + \
> + """
> + BR2_PACKAGE_PERL=y
> + BR2_PACKAGE_PERL_LIBWWW_PERL=y
> + """
> +
> + def test_run(self):
> + self.login()
> + self.module_test("LWP")
> + self.module_test("LWP::UserAgent")
> + self.module_test("LWP::Authen::Basic")
> + self.module_test("LWP::Authen::Digest")
> + self.module_test("HTTP::Message")
> + self.module_test("HTTP::Daemon")
> + self.module_test("WWW::RobotRules")
Why are you testing specifically those modules ? What is the rule to
decide what modules are tested here ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-11-24 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 9:07 [Buildroot] [PATCH/next v3 0/8] suppport/testing: Perl interpreter and CPAN modules Francois Perrad
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 1/8] support/testing: add perl test Francois Perrad
2018-11-27 2:24 ` Ricardo Martincoski
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 2/8] scancpan: add generation of test Francois Perrad
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 3/8] support/testing: add perl-class-load test Francois Perrad
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 4/8] support/testing: add perl-gdgraph test Francois Perrad
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 5/8] support/testing: add perl-libwww-perl test Francois Perrad
2018-11-24 10:06 ` Thomas Petazzoni [this message]
2018-11-24 10:56 ` François Perrad
2018-11-24 11:37 ` Thomas Petazzoni
2018-11-24 13:42 ` François Perrad
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 6/8] support/testing: add perl-mail-dkim test Francois Perrad
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 7/8] support/testing: add perl-x10 test Francois Perrad
2018-11-24 9:07 ` [Buildroot] [PATCH/next v3 8/8] support/testing: add perl-xml-libxml test Francois Perrad
2018-12-03 19:53 ` [Buildroot] [PATCH/next v3 0/8] suppport/testing: Perl interpreter and CPAN modules Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181124110608.681120b2@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox