From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] valgrind: fix mips64 compile
Date: Wed, 28 Nov 2018 15:28:45 +0100 [thread overview]
Message-ID: <20181128152845.7b9d1904@windsurf> (raw)
In-Reply-To: <20181108230814.4773-1-ps.report@gmx.net>
Hello,
On Fri, 9 Nov 2018 00:08:14 +0100, Peter Seiderer wrote:
> diff --git a/package/valgrind/0003-configure.ac-disable-gcc-march-mips64r2-detection.patch b/package/valgrind/0003-configure.ac-disable-gcc-march-mips64r2-detection.patch
> new file mode 100644
> index 0000000000..75874fe7fd
> --- /dev/null
> +++ b/package/valgrind/0003-configure.ac-disable-gcc-march-mips64r2-detection.patch
> @@ -0,0 +1,58 @@
> +From a4584ead274388b91b05b94bad2452a5f0ad3530 Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Thu, 8 Nov 2018 23:55:30 +0100
> +Subject: [PATCH] configure.ac: disable gcc march mips64r2 detection
> +
> +Disable gcc march mips64r2 detection, compile flags already
> +set by buildroot, fixes [1]:
> +
> + error: '-mips64r2' conflicts with the other architecture options, which specify a mips64 processor
> +
> +[1] http://autobuild.buildroot.net/results/34f6e2352f1559f98c724fe5394db0035b42ddb1
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + configure.ac | 24 ++++++++++++------------
> + 1 file changed, 12 insertions(+), 12 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index c18ae5f2a..70bfe1bb6 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -1769,21 +1769,21 @@ case "${host_cpu}" in
> +
> +
> + # does this compiler support -march=mips64r2 (mips64r2 default) ?
> +- AC_MSG_CHECKING([if gcc accepts -march=mips64r2 -mabi=64])
> ++ #AC_MSG_CHECKING([if gcc accepts -march=mips64r2 -mabi=64])
Commenting out code in a patch is not very useful, removing it is
easier/simpler, so I changed this to just remove the problematic code.
> VALGRIND_INSTALL_STAGING = YES
> +# Patch 0001-configure.ac-disable-gcc-march-mips64r2-detection.patch
Actually it's patch 0003, so I fixed that as well.
Applied to master with those minor issues fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-28 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-08 23:08 [Buildroot] [PATCH v1] valgrind: fix mips64 compile Peter Seiderer
2018-11-09 10:55 ` Thomas Petazzoni
2018-11-12 18:41 ` Peter Seiderer
2018-11-28 14:28 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181128152845.7b9d1904@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox