Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/wolfssl: enable ARMv8 hardware acceleration
Date: Thu, 29 Nov 2018 22:34:01 +0100	[thread overview]
Message-ID: <20181129223401.77beba29@windsurf> (raw)
In-Reply-To: <20181125092027.5824-1-sergio.prado@e-labworks.com>

Hello,

On Sun, 25 Nov 2018 07:20:27 -0200, Sergio Prado wrote:

> -# build fails when ARMv8 hardware acceleration is enabled
> +# enable ARMv8 hardware acceleration (the flag -mstrict-align is
> +# needed to prevent build errors caused by some inline assembly
> +# in parts of the AES structure using the "m" constraint)
> +ifeq ($(BR2_ARM_CPU_ARMV8A),y)
> +WOLFSSL_CONF_OPTS += --enable-armasm
> +WOLFSSL_CONF_ENV += CPPFLAGS="$(TARGET_CPPFLAGS) -mstrict-align"

Actually, this doesn't work well when doing an ARM 32 bit configuration
targeting Cortex-A53. Cortex-A53 is an ARMv8-A core, so
BR2_ARM_CPU_ARMV8A=y, but the gcc for ARM 32 bits doesn't support
-mstrict-align, causing a build failure.

However, the ARM optimization of wolfssl applies to both ARMv8 in 32 and
64 bits mode. So I've added another condition on BR2_aarch64=y around
the -mstrict-align workaround.

Applied with this change. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2018-11-29 21:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25  9:20 [Buildroot] [PATCH] package/wolfssl: enable ARMv8 hardware acceleration Sergio Prado
2018-11-29 21:34 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129223401.77beba29@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox