Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 2/2] squid: needs atomic
Date: Thu, 29 Nov 2018 22:58:44 +0100	[thread overview]
Message-ID: <20181129225844.2e72e404@windsurf> (raw)
In-Reply-To: <20181124145450.5623-2-fontaine.fabrice@gmail.com>

Hello,

On Sat, 24 Nov 2018 15:54:50 +0100, Fabrice Fontaine wrote:
> Since https://github.com/squid-cache/squid/commit/4b0f89121135aae68fbaf2aa33b5fb2e0da66d3e
> squid tries to find if latomic is needed through:
> AC_SEARCH_LIBS([__atomic_load_8],[atomic],[ATOMICLIB="-latomic"],[])
> 
> However, this can fails on:
> configure:21147: /home/fabrice/buildroot/output/host/bin/arc-buildroot-linux-gnu-g++ -o conftest -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -matomic -Os   -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -g conftest.cpp -latomic   >&5
> conftest.cpp:55:6: error: new declaration 'char __atomic_load_8()' ambiguates built-in declaration 'long long unsigned int __atomic_load_8(const volatile void*, int)' [-fpermissive]
>  char __atomic_load_8 ();
>       ^~~~~~~~~~~~~~~
> conftest.cpp: In function 'int main()':
> conftest.cpp:59:25: error: too few arguments to function 'long long unsigned int __atomic_load_8(const volatile void*, int)'
>  return __atomic_load_8 ();

I've applied to next, but could you fix the upstream code so that the
-latomic detection works correctly, and we can drop the workaround in
Buildroot at some point in the future ?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-11-29 21:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24 14:54 [Buildroot] [PATCH/next 1/2] squid: remove gnu atomics handling Fabrice Fontaine
2018-11-24 14:54 ` [Buildroot] [PATCH/next 2/2] squid: needs atomic Fabrice Fontaine
2018-11-29 21:58   ` Thomas Petazzoni [this message]
2018-11-29 21:58 ` [Buildroot] [PATCH/next 1/2] squid: remove gnu atomics handling Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129225844.2e72e404@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox