From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt5declarative: fix debug build with uclibc
Date: Fri, 30 Nov 2018 09:00:07 +0100 [thread overview]
Message-ID: <20181130090007.11a48750@windsurf> (raw)
In-Reply-To: <20181130002016.7440-1-fontaine.fabrice@gmail.com>
Hello,
On Fri, 30 Nov 2018 01:20:16 +0100, Fabrice Fontaine wrote:
> Debug build of qsgtexture fails on uclibc since version 5.11 and
> https://github.com/qt/qtdeclarative/commit/7c507eaac3f848f92f2ebdafe8ded4a064d68351:
>
> scenegraph/util/qsgtexture.cpp:69:22: fatal error: execinfo.h: No such file or directory
> #include <execinfo.h>
>
> Indeed, !defined(__UCLIBC__) has been replaced by defined(__GBLIBC__) to
> fix build on musl but as a result, build fails on uclibc because uclibc
> also defines __GLIBC__ (and it does not have execinfo like musl)
>
> This error is raised only when building in debug mode because
> CAN_BACKTRACE_EXECINFO is undefined if QT_NO_DEBUG is set
>
> So keep defined(__GLIBC__), but put back !defined(__UCLIBC__)
>
> Fixes:
> - http://autobuild.buildroot.org/results/6fce0ce5aea943e097532efbbc8d1e28f41e5866
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Thanks applied to master.
> +[Upstream status: https://github.com/qt/qtdeclarative/pull/4]
I don't think opening a pull request on Github is the right way to
contribute to Qt upstream. They have a Gerrit, and you need to submit
your contribution there, if I remember correctly. Peter Seiderer (in
Cc) can probably help in this process, either by giving you additional
details, or pushing the patch upstream for you perhaps.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2018-11-30 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-30 0:20 [Buildroot] [PATCH 1/1] qt5declarative: fix debug build with uclibc Fabrice Fontaine
2018-11-30 8:00 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130090007.11a48750@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox