Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next v3] package/luarocks: rework configuration file for per-package folders
Date: Sat, 1 Dec 2018 22:55:10 +0100	[thread overview]
Message-ID: <20181201225510.43ca2908@windsurf.home> (raw)
In-Reply-To: <20181130103829.32241-1-thomas.petazzoni@bootlin.com>

Hello,

On Fri, 30 Nov 2018 11:38:29 +0100, Thomas Petazzoni wrote:
> Currently, luarocks.mk generates a configuration file with hardcoded
> STAGING_DIR, TARGET_DIR, TARGET_CC, LUAROCKS_CFLAGS and TARGET_LDFLAGS
> values. This is not compatible with per-package folders, where the
> value of STAGING_DIR, TARGET_DIR, TARGET_CC and possibly
> TARGET_CFLAGS/TARGET_LDFLAGS may be different from one package to the
> other.
> 
> Based on input from Fran?ois Perrad, this commit:
> 
>  - Changes the Luarocks configuration file to use os_getenv() for the
>    appropriate variables. Since the contents of this file is not
>    fixed, it is no longer generated by luarocks.mk using a series of
>    'echo' but simply concatenated with the rest of the Luarocks
>    configuration file.
> 
>  - Adjusts LUAROCKS_RUNV_ENV so that the necessary environment
>    variables are now passed.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> Changes since v2:
>  - Do not pass STAGING_DIR/TARGET_DIR in LUAROCKS_RUN_ENV, since they
>    are already exported globally in the environment. Suggested by
>    Arnout Vandecappelle.

Applied to next, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-12-01 21:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-30 10:38 [Buildroot] [PATCH next v3] package/luarocks: rework configuration file for per-package folders Thomas Petazzoni
2018-12-01  8:39 ` François Perrad
2018-12-01 21:55 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181201225510.43ca2908@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox