Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC PATCH] host-localedef: Compile against glibc
Date: Wed, 5 Dec 2018 23:20:58 +0100	[thread overview]
Message-ID: <20181205232058.7ce7d457@gmx.net> (raw)
In-Reply-To: <20180801083938.23914da0@windsurf>

Hello *,

On Wed, 1 Aug 2018 08:39:38 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

> Hello,
> 
> On Wed, 01 Aug 2018 11:31:16 +1000, Samuel Mendoza-Jonas wrote:
> 
> > I think it's a bit of both; 2.27 introduces new locale descriptions which
> > localedef can't handle, eg:
> > 
> > Generating locale ru_RU.UTF-8
> > /scratch/jenkins-workspace/op-build-upstream/output/host/powerpc64le-buildroot-linux-gnu/sysroot/usr/share/i18n/locales/ru_RU:125: LC_TIME:syntax error
> > /scratch/jenkins-workspace/op-build-upstream/output/host/powerpc64le-buildroot-linux-gnu/sysroot/usr/share/i18n/locales/ru_RU:149: LC_TIME:syntax error  
> 
> Ah, so I guess this update of localedef is going to fix
> https://bugs.busybox.net/show_bug.cgi?id=11096.
> 
> > And we fall back to the C locale at runtime (at least in my environment).
> > I'll stare at the glibc release notes / bug report a bit more and see if
> > I can make a more legible explanation.  
> 
> Would be nice, though it generally makes sense to have a localedef
> implementation that is in sync with glibc.
> 
> > > See how they are doing it in PTXdist:
> > > https://git.pengutronix.de/cgit/ptxdist/tree/rules/host-localedef.make.
> > > Most likely using the locale/others make target will help cut the build
> > > time significantly.    
> > 
> > Yes this is the contentious part, we're building a whole glibc. Unfortunately
> > if we want to build just the locale/others target like PTXdist we also need
> > their bonus patch to glibc:
> > https://git.pengutronix.de/cgit/ptxdist/tree/patches/localedef-glibc-2.27/0001-HACK-only-build-and-install-localedef.patch
> > 
> > Otherwise the build fails with, for example:
> > 
> > make[4]: *** No rule to make target '/scratch/builds/locales/build/host-localedef-glibc-2.27-57-g6c99e37f6fb640a50a3113b2dbee5d5389843c1e/build/elf/soinit.os', needed by '/scratch/builds/locales/build/host-localedef-glibc-2.27-57-g6c99e37f6fb640a50a3113b2dbee5d5389843c1e/build/libc.so'.  Stop.
> > Makefile:215: recipe for target 'locale/others' failed
> > make[3]: *** [locale/others] Error 2
> > Makefile:9: recipe for target 'locale/others' failed
> > make[2]: *** [locale/others] Error 2
> > 
> > So the tradeoff is adding a few minutes of extra build time versus carrying
> > a bit of a hack to enable just the localedef/others target.  
> 
> Their patch is not that crazy IMO, it should be too complicated to
> maintain. Perhaps we could even improve it a bit further to make it
> acceptable upstream ?
> 
> Best regards,
> l
> Thomas

Just stumbled over the same (or similar) locale problem with buildroot-2018.11/glibc-2.28,
fixed by the suggested patch. Just send out a follow up RFC patch with various comments addressed,
fixes and updates, see [1]...

Regards,
Peter

[1] https://patchwork.ozlabs.org/patch/1008473/

      reply	other threads:[~2018-12-05 22:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30  5:39 [Buildroot] [RFC PATCH] host-localedef: Compile against glibc Samuel Mendoza-Jonas
2018-07-31  0:52 ` Joel Stanley
2018-07-31 20:55 ` Thomas Petazzoni
2018-08-01  1:31   ` Samuel Mendoza-Jonas
2018-08-01  6:39     ` Thomas Petazzoni
2018-12-05 22:20       ` Peter Seiderer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205232058.7ce7d457@gmx.net \
    --to=ps.report@gmx.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox