Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5base: fix build when system awk is mawk, not gawk
Date: Thu, 6 Dec 2018 21:10:45 +0100	[thread overview]
Message-ID: <20181206211045.41106d28@windsurf> (raw)
In-Reply-To: <20181205110223.27310-1-yann.morin.1998@free.fr>

Hello,

On Wed,  5 Dec 2018 12:02:23 +0100, Yann E. MORIN wrote:
> Commit c2ea056a1b (package/qt5/qt5base: use ccache for building host
> code) introduced a tweak to qt5's mkspec file, to define the compilers
> (C and C++) to use to build qmake.
> 
> In doing so, it changed the variables in that file, from this layout:
>     VAR = value
> 
> to this:
>     VAR=value
> 
> During its configuration phase, qt5 will parse that file using the
> system awk.
> 
> However, the system awk is not necessarily GNU awk; some systems,
> especially Debian ones, use mawk as the default awk implementation.
> 
> mawk does not behave the same as GNU awk, and this causes qt5 to extract
> empty values, and thus leads to build failures.
> 
> Fix that by replacing the variables with similar layout, keeping the
> spaces around the equal signs.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/cb5/cb555a124bb3bdb9c5a3465673c21022d94cf2ca/
> 
> Reported-by: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-12-06 20:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 11:02 [Buildroot] [PATCH] package/qt5base: fix build when system awk is mawk, not gawk Yann E. MORIN
2018-12-05 13:00 ` Thomas Petazzoni
2018-12-05 14:28   ` Alexey Brodkin
2018-12-06 20:10 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206211045.41106d28@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox