Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3, 2/2] lxc: fix build without stack protector
Date: Thu, 6 Dec 2018 21:20:16 +0100	[thread overview]
Message-ID: <20181206212016.3bb66b83@windsurf> (raw)
In-Reply-To: <20181204201553.11463-2-fontaine.fabrice@gmail.com>

Hello,

On Tue,  4 Dec 2018 21:15:53 +0100, Fabrice Fontaine wrote:
> Stack protector has been added in version 3.0.3 by
> https://github.com/lxc/lxc/commit/2268c27754152aa538db2c9e3753d72d19bcd17a
> 
> However, some compilers could missed the needed library (-lssp or
> -lssp_nonshared) at linking step so use ax_check_link_flag instead of
> ax_check_compile_flag
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/0b90e7dca2984652842832a41abad93ac49a9b86
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Baruch Siach):
>  - Add patch to use ac_check_link_flag

Applied to master, thanks. I think you could submit upstream, it's a
fix that makes sense to have.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-12-06 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 20:15 [Buildroot] [PATCH v3,1/2] lxc: fix missing include for va_list Fabrice Fontaine
2018-12-04 20:15 ` [Buildroot] [PATCH v3,2/2] lxc: fix build without stack protector Fabrice Fontaine
2018-12-06 20:20   ` Thomas Petazzoni [this message]
2018-12-09 21:37   ` [Buildroot] [PATCH v3, 2/2] " Peter Korsgaard
2018-12-06 20:19 ` [Buildroot] [PATCH v3, 1/2] lxc: fix missing include for va_list Thomas Petazzoni
2018-12-09 21:37 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206212016.3bb66b83@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox